Skip to content

fix: enable terminal title control via change_title MCP tool #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michelhelsdingen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: enable terminal title control via change_title MCP tool #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e14cfa
fix(mode-switch): signal forwarding prevents orphaned processes (#11)
michelhelsdingen Feb 3, 2026
fd1d379
fix: re-enable terminal title control via change_title MCP tool
michelhelsdingen Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "happy-coder",
"version": "0.14.0-0",
"version": "0.14.1-0",
"description": "Mobile and Web client for Claude Code and Codex",
"author": "Kirill Dubovitskiy",
"license": "MIT",
Expand Down
3 changes: 3 additions & 0 deletions scripts/claude_local_launcher.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ const fs = require('fs');
// Disable autoupdater (never works really)
process.env.DISABLE_AUTOUPDATER = '1';

// Disable Claude Code's terminal title setting so Happy CLI can control it
process.env.CLAUDE_CODE_DISABLE_TERMINAL_TITLE = '1';

// Helper to write JSON messages to fd 3
function writeMessage(message) {
try {
Expand Down
13 changes: 13 additions & 0 deletions scripts/claude_version_utils.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,19 @@ function runClaudeCli(cliPath) {
stdio: 'inherit',
env: process.env
});

// Forward signals to child process so it gets killed when parent is killed
// This prevents orphaned Claude processes when switching between local/remote modes
// Fix for issue #11 / GitHub slopus/happy#430
const forwardSignal = (signal) => {
if (child.pid && !child.killed) {
child.kill(signal);
}
};
process.on('SIGTERM', () => forwardSignal('SIGTERM'));
process.on('SIGINT', () => forwardSignal('SIGINT'));
process.on('SIGHUP', () => forwardSignal('SIGHUP'));

child.on('exit', (code) => {
process.exit(code || 0);
});
Expand Down
23 changes: 23 additions & 0 deletions src/claude/claudeLocal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,29 @@ export async function claudeLocal(opts: {
env,
});

// Forward signals to child process to prevent orphaned processes
// Fix for issue #11 / GitHub slopus/happy#430
// Note: signal: opts.abort handles programmatic abort (mode switching),
// but direct OS signals (e.g., kill, Ctrl+C) need explicit forwarding
const forwardSignal = (signal: NodeJS.Signals) => {
if (child.pid && !child.killed) {
child.kill(signal);
}
};
const onSigterm = () => forwardSignal('SIGTERM');
const onSigint = () => forwardSignal('SIGINT');
const onSighup = () => forwardSignal('SIGHUP');
process.on('SIGTERM', onSigterm);
process.on('SIGINT', onSigint);
process.on('SIGHUP', onSighup);

// Cleanup signal handlers when child exits to avoid leaks
child.on('exit', () => {
process.off('SIGTERM', onSigterm);
process.off('SIGINT', onSigint);
process.off('SIGHUP', onSighup);
});

// Listen to the custom fd (fd 3) for thinking state tracking
if (child.stdio[3]) {
const rl = createInterface({
Expand Down
16 changes: 14 additions & 2 deletions src/claude/utils/startHappyServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,30 @@ import { logger } from "@/ui/logger";
import { ApiSessionClient } from "@/api/apiSession";
import { randomUUID } from "node:crypto";

/**
* Set the terminal window title using OSC escape sequences.
* Works with iTerm2, Terminal.app, and most modern terminal emulators.
* Uses OSC 0 which sets both window title and icon name.
*/
function setTerminalTitle(title: string): void {
process.stdout.write(`\x1b]0;${title}\x07`);
}

export async function startHappyServer(client: ApiSessionClient) {
// Handler that sends title updates via the client
const handler = async (title: string) => {
logger.debug('[happyMCP] Changing title to:', title);
try {
// Send title as a summary message, similar to title generator
// Set the terminal window title (iTerm2, Terminal.app, etc.)
setTerminalTitle(title);

// Also send title as a summary message to Happy server (for mobile app)
client.sendClaudeSessionMessage({
type: 'summary',
summary: title,
leafUuid: randomUUID()
});

return { success: true };
} catch (error) {
return { success: false, error: String(error) };
Expand Down