Primitive_object.equal treats empty array as Some(None)

[zth]

It appears that Primitive_object.equal mistakenly treats [] as Some(None). I can't think of a reason for this being intentional, so I think it's a bug.

This ReScript code logs true:

let check = v => v == Some(None)

Console.log(check(%raw(`[]`)))

But an empty array is not Some(None), so it should be logging false.

Playground: https://rescript-lang.org/try/?version=v12.0.0-rc.1&module=esmodule&code=DYUwLgBAxgFiUGsIF4IDcUD50tQZQHsBbEACgDkCA7EASgCh6BhagZwNADpgCBzU2PASkApACcAhgHdSAAwDaAXVm1VQA

[cristianoc]

It appears that Primitive_object.equal mistakenly treats [] as Some(None). I can't think of a reason for this being intentional, so I think it's a bug.

This ReScript code logs true:

let check = v => v == Some(None)

Console.log(check(%raw([])))
But an empty array is not Some(None), so it should be logging false.

Playground: https://rescript-lang.org/try/?version=v12.0.0-rc.1&module=esmodule&code=DYUwLgBAxgFiUGsIF4IDcUD50tQZQHsBbEACgDkCA7EASgCh6BhagZwNADpgCBzU2PASkApACcAhgHdSAAwDaAXVm1VQA

You're doing it all wrong
try

let check = v => Some(None) == v

Console.log(check(%raw(`[]`)))

[zth]

Of course.....

[cristianoc]

Of course.....

Joking aside there's an explanation.
Equality is intended to be used on typed values. If the lhs is an empty array, then it's equal to the rhs as it also has length 0.
So to get a more general equality which does not assume well-typedness, one needs to add more check to the implementation.