Rethink built-in static-analysis #730
Description
Is your feature request related to a problem? Please describe.
All of our config patchers and static analyses are built into penguin. There are a few issues here:
- not customizable
- single shot
- harder to test
Describe the solution you'd like
I think it'd be good if we took most of the built-in analyses out of penguin and turned them into plugins.
This makes them more accessible and easier to re-test.
This means that they'd run and cache their results on the first run. On subsequent runs they wouldn't have anything to do. However, if we delete their result they could track that and re-run.
Describe alternatives you've considered
I haven't. It's still a pretty early thought.
Additional context
I think the logic around some patchgenerators and config static_analyses are a bit broken and we just sort-of disable them rather than adjusting the plugins and re-checking. I think a major reason is that it's more complicated to delete and re-initialize the project. It's also an expensive operation.