Skip to content

Frame properties disappeared (possible regression) #52

@pinterf

Description

@pinterf

As per this forum post by FranceBB
https://forum.doom9.org/showthread.php?p=2027669#post2027669
the frame properties has been killed and are not getting passed over.

I think this commit, which replaced make_writeable with a manual frame copy, did it.
716df2f

avs_make_writable(p->env, &src); makes a complete content copy if needed, and preserves frame properties of source.
Unlike dst = avs_new_video_frame_a(p->env, &p->vi, AVS_FRAME_ALIGN);
Which kills them.
However avs_new_video_frame_p_a has a source frame property parameter, but since I don't know why avs_make_writable was replaced, I recommend it only if we really have to use avs_new_video_frame_xx construct.

@seiya-git:
Why did you make manual copy, since make_writeable is doing exactly the same. I remember making a comment on it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions