Skip to content

Fix image sync detection to log both source and target digests for debugging #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepsm007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix image sync detection to log both source and target digests for debugging #4908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions cmd/ci-images-mirror/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,20 @@ func (s *supplementalCIImagesServiceWithMirrorStore) Mirror(m map[string]quayioc
continue
}

// Skip if digests match
// Skip if digests match (both must be non-empty to compare)
// If target doesn't exist (empty digest), we need to sync
if targetInfo.Digest != "" && sourceInfo.Digest != "" && targetInfo.Digest == sourceInfo.Digest {
s.logger.WithField("target", targetImage).WithField("digest", targetInfo.Digest).Debug("Image already in sync, skipping")
s.logger.WithField("target", targetImage).WithField("source", source).
WithField("sourceDigest", sourceInfo.Digest).WithField("targetDigest", targetInfo.Digest).
Debug("Image already in sync, skipping")
continue
}

// Log sync needed with digest details for debugging
s.logger.WithField("source", source).WithField("target", targetImage).
WithField("sourceDigest", sourceInfo.Digest).WithField("targetDigest", targetInfo.Digest).
Info("Image needs sync")

s.logger.WithField("source", source).WithField("target", targetImage).
WithField("sourceDigest", sourceInfo.Digest).WithField("targetDigest", targetInfo.Digest).
Info("Image needs sync")
Expand Down