Skip to content

ci-operator: Enable ErrTypeNotFound on the lease client #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danilo-gemoli wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

ci-operator: Enable ErrTypeNotFound on the lease client #4893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/lease/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ type boskosClient interface {
Metric(rtype string) (common.Metric, error)
}

var ErrNotFound = boskos.ErrNotFound
var (
// ErrNotFound is returned when no resources of the requested type are currently available.
ErrNotFound = boskos.ErrNotFound
// ErrTypeNotFound is returned when the requested resource type does not exist.
ErrTypeNotFound = boskos.ErrTypeNotFound
)

type Metrics struct {
Free, Leased int
Expand Down Expand Up @@ -68,6 +73,7 @@ func NewClient(owner, url, username string, passwordGetter func() []byte, retrie
if err != nil {
return nil, err
}
c.DistinguishNotFoundVsTypeNotFound = true
return newClient(c, retries, acquireTimeout), nil
}

Expand Down