-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Hi,
I'm not sure if this is intentional, if this was a bug, or if my understanding was incorrect, so I wanted to check here.
When you use create_abd_from_h5(), with the default convention = 'SpEC' option, to for example load in a CCE simulation from the public CCE catalog, the psi4 data is multiplied by a factor of 0.5 internally due to convention='SpEC'. However, when you retrieve the psi4 data, using for example abd.psi4, the reverse transformation (i.e. multiply by 2) is not applied so the returned psi4 data is different than the psi4 data loaded in.
For the strain, this does not seem to be an issue since the def h() method in AsymptoticBondiData class multiplies sigma by 2 before returning the strain, so the strain loaded in from the CCE file is the same as the strain retrieved through abd.h
I wanted to make sure my understanding of this was correct and check whether this was intentional or a bug?
Thanks!