Skip to content

fix: skip e2e live connection tests when SQL auth credentials unavailable #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dlevy-msft-sql wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: skip e2e live connection tests when SQL auth credentials unavailable #659

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
987ca66
fix: skip live connection tests when SQL auth credentials unavailable
dlevy-msft-sql Jan 28, 2026
bb3bb71
fix: generalize Azure AD comment per code review
dlevy-msft-sql Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions cmd/modern/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ func hasLiveConnection() bool {
return os.Getenv("SQLCMDSERVER") != ""
}

// hasSQLAuthCredentials returns true if SQL authentication credentials are available.
// For Azure AD/Entra authentication methods, we need different handling.
func hasSQLAuthCredentials() bool {
return os.Getenv("SQLCMDUSER") != "" && os.Getenv("SQLCMDPASSWORD") != ""
}

// skipIfNoLiveConnection skips the test if no live SQL Server connection is available.
func skipIfNoLiveConnection(t *testing.T) {
t.Helper()
Expand All @@ -80,6 +86,17 @@ func skipIfNoLiveConnection(t *testing.T) {
}
}

// skipIfNoSQLAuth skips the test if SQL authentication credentials are not available.
// Tests requiring SQL auth should use this instead of skipIfNoLiveConnection when they
// don't support Azure AD/Entra authentication.
func skipIfNoSQLAuth(t *testing.T) {
t.Helper()
skipIfNoLiveConnection(t)
if !hasSQLAuthCredentials() {
t.Skip("Skipping: SQLCMDUSER/SQLCMDPASSWORD not set, SQL auth not available (may be using Azure AD)")
}
}

type buildError struct {
err error
output string
Expand Down Expand Up @@ -143,9 +160,10 @@ func TestE2E_PipedInput_NoPanic(t *testing.T) {
}

// TestE2E_PipedInput_LiveConnection tests piping input with a real SQL Server connection.
// This test only runs when SQLCMDSERVER is set.
// This test only runs when SQLCMDSERVER and SQL auth credentials are set.
// It does not support Azure AD/Entra authentication yet.
func TestE2E_PipedInput_LiveConnection(t *testing.T) {
skipIfNoLiveConnection(t)
skipIfNoSQLAuth(t)
binary := buildBinary(t)

cmd := exec.Command(binary, "-C")
Expand Down Expand Up @@ -208,9 +226,9 @@ func TestE2E_QueryFlag_NoServer(t *testing.T) {
}

// TestE2E_QueryFlag_LiveConnection tests the -Q flag with a real SQL Server connection.
// This test only runs when SQLCMDSERVER is set.
// This test only runs when SQLCMDSERVER and SQL auth credentials are set.
func TestE2E_QueryFlag_LiveConnection(t *testing.T) {
skipIfNoLiveConnection(t)
skipIfNoSQLAuth(t)
binary := buildBinary(t)

cmd := exec.Command(binary, "-C", "-Q", "SELECT 42 AS Answer")
Expand All @@ -237,9 +255,9 @@ func TestE2E_InputFile_NotFound(t *testing.T) {
}

// TestE2E_InputFile_LiveConnection tests the -i flag with a real SQL Server connection.
// This test only runs when SQLCMDSERVER is set.
// This test only runs when SQLCMDSERVER and SQL auth credentials are set.
func TestE2E_InputFile_LiveConnection(t *testing.T) {
skipIfNoLiveConnection(t)
skipIfNoSQLAuth(t)
binary := buildBinary(t)

// Create a temporary SQL file
Expand Down
Loading