Skip to content

Incorrect group processing in CMidi2UMP2BSMidiTransform::SendMidiMessage could result in incorrect group assignment for messages #829

@Psychlist1972

Description

@Psychlist1972

CMidi2UMP2BSMidiTransform::SendMidiMessage processes an entire stream of incoming UMP messages, but only takes into account the last group index from the translation. Instead, it needs to use the iterator to process the stream and send whenever the group index changes. Otherwise, messages end up going to incorrect groups.

Related: #822

External Related: midi2-dev/AM_MIDI2.0Lib#30

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-service-or-api 🖥️Related to the Windows Service, core API, abstractions, etc.bug 🐞Something isn't workingcritical ‼️Critical to be fixed/implemented before next major release

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions