Skip to content

MM-67120: Upgrade mattermost-plugin-github webapp to React 18 #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nevyangelova wants to merge 1 commit into
base: master
Choose a base branch
from
+4,496 −18,921
Open

MM-67120: Upgrade mattermost-plugin-github webapp to React 18 #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webapp/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
]
},
"react": {
"version": "16.13.1"
"version": "detect"
}
},
"rules": {
Expand Down
75 changes: 34 additions & 41 deletions webapp/babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,39 @@
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.

const config = {
presets: [
['@babel/preset-env', {
targets: {
chrome: 66,
firefox: 60,
edge: 42,
safari: 12,
},
modules: false,
corejs: 3,
debug: false,
useBuiltIns: 'usage',
shippedProposals: true,
}],
['@babel/preset-react', {
useBuiltIns: true,
}],
['@babel/typescript', {
allExtensions: true,
isTSX: true,
}],
['@emotion/babel-preset-css-prop'],
],
plugins: [
'@babel/plugin-proposal-class-properties',
'@babel/plugin-syntax-dynamic-import',
'@babel/proposal-object-rest-spread',
'@babel/plugin-proposal-optional-chaining',
'babel-plugin-typescript-to-proptypes',
],
};
module.exports = (api) => {
const isTest = api.env('test');

// Jest needs module transformation
config.env = {
test: {
presets: config.presets,
plugins: config.plugins,
},
return {
presets: [
['@babel/preset-env', {
targets: {
chrome: 66,
firefox: 60,
edge: 42,
safari: 12,
},
modules: isTest ? 'auto' : false,
corejs: 3,
debug: false,
useBuiltIns: 'usage',
shippedProposals: true,
}],
['@babel/preset-react', {
runtime: 'automatic',
}],
['@babel/preset-typescript', {
allExtensions: true,
isTSX: true,
}],
['@emotion/babel-preset-css-prop'],
],
plugins: [
'@babel/plugin-transform-class-properties',
'@babel/plugin-syntax-dynamic-import',
'@babel/plugin-transform-object-rest-spread',
'@babel/plugin-transform-optional-chaining',
'babel-plugin-typescript-to-proptypes',
],
};
};
config.env.test.presets[0][1].modules = 'auto';

module.exports = config;
Loading
Loading