Skip to content

Update vtx_smartaudio.c #11285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skorya wants to merge 1 commit into from
+1 −1
Closed

Update vtx_smartaudio.c #11285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/io/vtx_smartaudio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ static serialPort_t *smartAudioSerialPort = NULL;

uint8_t saPowerCount = VTX_SMARTAUDIO_DEFAULT_POWER_COUNT;
const char *saPowerNames[VTX_SMARTAUDIO_MAX_POWER_COUNT + 1] = {
"----", "25 ", "200 ", "500 ", "800 ", " ", " ", " ", " "
"25", "200 ", "500 ", "1000 ", "3000 ", " ", " ", " ", " "
};
Comment on lines 64 to 66
Copy link
Contributor

@qodo-code-review qodo-code-review bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Truncate the power name strings to a maximum of 4 characters to prevent a potential buffer overflow when they are copied into the sa21PowerNames buffer. [possible issue, importance: 9]

Suggested change
const char *saPowerNames[VTX_SMARTAUDIO_MAX_POWER_COUNT + 1] = {
"----", "25 ", "200 ", "500 ", "800 ", " ", " ", " ", " "
"25", "200 ", "500 ", "1000 ", "3000 ", " ", " ", " ", " "
};
const char *saPowerNames[VTX_SMARTAUDIO_MAX_POWER_COUNT + 1] = {
"25", "200", "500", "1000", "3000", " ", " ", " ", " "
};


// Save powerlevels reported from SA 2.1 devices here
Expand Down