Wrong hashCode and equality check for Map<String, dynamic>

[AlxSidenko]

In one of my models i have a property like this 'final Map<String, dynamic>? extra'.
How it's handling now in hashCode and ==:

hashCode
...
l$extra

==
...
final l$extra = extra;
    final lOther$extra = other.extra;
    if (l$extra != lOther$extra) {
      return false;
}

How it must be:

hashCode
...
l$extra == null ? null : const DeepCollectionEquality().hash(l$extra)

==
...
final l$extra = extra;
    final lOther$extra = other.extra;
    if (!const DeepCollectionEquality().equals(l$extra, lOther$extra)) {
      return false;
}

[github-actions]

👋 @AlxSidenko
Thank you for raising an issue. I will investigate the issue and get back to you as soon as possible.
Please make sure you have provided enough context.

This library is created and maintained by me, @budde377. Please consider supporting my work and ensure our survival by donating here.

[budde377]

Please provide some more context. What does your schema look like?

[AlxSidenko]

Model in schema

type Contact {
  id: ID!
  firstName: String!
  lastName: String
  email: String
  phone: Phone
  memo: String
  extra: Map
  tagIDs: [ID!]
  discounts: [Discount!]
}

Map scalar in build.yaml

graphql_codegen:
  options:
    scalars:
      Map:
        type: Map<String, dynamic>

Generated model

class Fragment$Contact {
  Fragment$Contact({
    required this.id,
    required this.firstName,
    this.lastName,
    this.email,
    this.phone,
    this.memo,
    this.extra,
    this.tagIDs,
    this.discounts,
  });

  factory Fragment$Contact.fromJson(Map<String, dynamic> json) {
    final l$id = json['id'];
    final l$firstName = json['firstName'];
    final l$lastName = json['lastName'];
    final l$email = json['email'];
    final l$phone = json['phone'];
    final l$memo = json['memo'];
    final l$extra = json['extra'];
    final l$tagIDs = json['tagIDs'];
    final l$discounts = json['discounts'];
    return Fragment$Contact(
      id: (l$id as String),
      firstName: (l$firstName as String),
      lastName: (l$lastName as String?),
      email: (l$email as String?),
      phone: l$phone == null
          ? null
          : Fragment$Phone.fromJson((l$phone as Map<String, dynamic>)),
      memo: (l$memo as String?),
      extra: (l$extra as Map<String, dynamic>?),
      tagIDs: (l$tagIDs as List<dynamic>?)?.map((e) => (e as String)).toList(),
      discounts: (l$discounts as List<dynamic>?)
          ?.map((e) => Fragment$Discount.fromJson((e as Map<String, dynamic>)))
          .toList(),
    );
  }

  final String id;

  final String firstName;

  final String? lastName;

  final String? email;

  final Fragment$Phone? phone;

  final String? memo;

  final Map<String, dynamic>? extra;

  final List<String>? tagIDs;

  final List<Fragment$Discount>? discounts;

  Map<String, dynamic> toJson() {
    final _resultData = <String, dynamic>{};
    final l$id = id;
    _resultData['id'] = l$id;
    final l$firstName = firstName;
    _resultData['firstName'] = l$firstName;
    final l$lastName = lastName;
    _resultData['lastName'] = l$lastName;
    final l$email = email;
    _resultData['email'] = l$email;
    final l$phone = phone;
    _resultData['phone'] = l$phone?.toJson();
    final l$memo = memo;
    _resultData['memo'] = l$memo;
    final l$extra = extra;
    _resultData['extra'] = l$extra;
    final l$tagIDs = tagIDs;
    _resultData['tagIDs'] = l$tagIDs?.map((e) => e).toList();
    final l$discounts = discounts;
    _resultData['discounts'] = l$discounts?.map((e) => e.toJson()).toList();
    return _resultData;
  }

  @override
  int get hashCode {
    final l$id = id;
    final l$firstName = firstName;
    final l$lastName = lastName;
    final l$email = email;
    final l$phone = phone;
    final l$memo = memo;
    final l$extra = extra;
    final l$tagIDs = tagIDs;
    final l$discounts = discounts;
    return Object.hashAll([
      l$id,
      l$firstName,
      l$lastName,
      l$email,
      l$phone,
      l$memo,
      l$extra,
      l$tagIDs == null ? null : Object.hashAll(l$tagIDs.map((v) => v)),
      l$discounts == null ? null : Object.hashAll(l$discounts.map((v) => v)),
    ]);
  }

  @override
  bool operator ==(Object other) {
    if (identical(this, other)) {
      return true;
    }
    if (other is! Fragment$Contact || runtimeType != other.runtimeType) {
      return false;
    }
    final l$id = id;
    final lOther$id = other.id;
    if (l$id != lOther$id) {
      return false;
    }
    final l$firstName = firstName;
    final lOther$firstName = other.firstName;
    if (l$firstName != lOther$firstName) {
      return false;
    }
    final l$lastName = lastName;
    final lOther$lastName = other.lastName;
    if (l$lastName != lOther$lastName) {
      return false;
    }
    final l$email = email;
    final lOther$email = other.email;
    if (l$email != lOther$email) {
      return false;
    }
    final l$phone = phone;
    final lOther$phone = other.phone;
    if (l$phone != lOther$phone) {
      return false;
    }
    final l$memo = memo;
    final lOther$memo = other.memo;
    if (l$memo != lOther$memo) {
      return false;
    }
    final l$extra = extra;
    final lOther$extra = other.extra;
    if (l$extra != lOther$extra) {
      return false;
    }
    final l$tagIDs = tagIDs;
    final lOther$tagIDs = other.tagIDs;
    if (l$tagIDs != null && lOther$tagIDs != null) {
      if (l$tagIDs.length != lOther$tagIDs.length) {
        return false;
      }
      for (int i = 0; i < l$tagIDs.length; i++) {
        final l$tagIDs$entry = l$tagIDs[i];
        final lOther$tagIDs$entry = lOther$tagIDs[i];
        if (l$tagIDs$entry != lOther$tagIDs$entry) {
          return false;
        }
      }
    } else if (l$tagIDs != lOther$tagIDs) {
      return false;
    }
    final l$discounts = discounts;
    final lOther$discounts = other.discounts;
    if (l$discounts != null && lOther$discounts != null) {
      if (l$discounts.length != lOther$discounts.length) {
        return false;
      }
      for (int i = 0; i < l$discounts.length; i++) {
        final l$discounts$entry = l$discounts[i];
        final lOther$discounts$entry = lOther$discounts[i];
        if (l$discounts$entry != lOther$discounts$entry) {
          return false;
        }
      }
    } else if (l$discounts != lOther$discounts) {
      return false;
    }
    return true;
  }
}

[AlxSidenko]

For example this method I've created in extension on Fragment$Contact

bool isEqual(Fragment$Contact other) {
  final contactWithoutExtra = copyWith(extra: null);
  final otherWithoutExtra = other.copyWith(extra: null);
  final isExtraEqual = const DeepCollectionEquality().equals(extra, other.extra);

  return contactWithoutExtra == otherWithoutExtra && isExtraEqual;
}

Working well. But it's a workaround.