Skip to content

Enhance _extra_os_version function to handle special version patterns #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bc-lee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhance _extra_os_version function to handle special version patterns #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions xctestrunner/simulator_control/simtype_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,26 @@ def max_os_version(self):

def _extra_os_version(os_version_str):
"""Extracts os version float value from a given string."""
# Cut build version. E.g., cut 9.3.3 to 9.3.
if os_version_str.count('.') > 1:
os_version_str = os_version_str[:os_version_str.rfind('.')]
# We need to round the os version string in the simulator profile. E.g.,
# the maxRuntimeVersion of iPhone 5 is 10.255.255 and we could create iOS 10.3
# for iPhone 5.
return round(float(os_version_str), 1)
# Handle Apple's special version patterns:
# - x.255.255 or x.99.0 means "any version within major version x"
# - 65535.255.255 means "no version limit"

parts = os_version_str.split('.')
major = int(parts[0])

# Handle unlimited version (65535.x.x)
if major >= 65535:
return 999.99 # Return a very high version number for unlimited support

if len(parts) >= 2:
minor = int(parts[1])

# Handle x.255.x or x.99.x patterns - both mean "any minor version within major x"
if minor >= 99:
return float(f"{major}.99")

# Handle normal version patterns - use major.minor
return float(f"{major}.{minor}")

# Fallback for simple major version
return float(major)