-
Notifications
You must be signed in to change notification settings - Fork 24
fix autopilot command errors with new inputs #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@MarcusWentz is attempting to deploy a commit to the cow Team on Vercel. A member of the Team first needs to authorize it. |
|
All contributors have signed the CLA ✍️ ✅ |
📝 WalkthroughWalkthroughUpdated tutorial docs: command examples reformatted with explicit shell continuations; native price estimator descriptor changed to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA |
Updated the shadow API URL in the local test tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/cow-protocol/tutorials/solvers/local_test.md`:
- Line 30: The example uses the staging shadow endpoint (--shadow
https://barn.api.cow.fi/mainnet) while the prose calls it a “production
orderbook”; update the wording or the example so they match — either change the
earlier text to say “staging orderbook” (or “staging shadow endpoint”) or
replace the example URL with the production shadow endpoint (i.e., swap the
--shadow URL to the production endpoint) so the documentation is consistent;
locate the literal "--shadow https://barn.api.cow.fi/mainnet" in the tutorial
and update the surrounding sentence or the URL accordingly.
- Around line 26-31: The CLI examples use malformed argument formats: update the
--native-price-estimators and --drivers values to be simple name|url pairs per
autopilot docs; replace --native-price-estimators
"Driver|baseline|http://driver/baseline" with --native-price-estimators
"baseline|http://driver/baseline" and replace --drivers
"mysolver1|http://localhost:11088|0x0000000000000000000000000000000000000000|0"
with --drivers "mysolver1|http://localhost:11088" so both flags supply only
name|url entries.
Description
fix autopilot command errors with new inputs
Changes
Related Issues
cowprotocol/services#4063
cowprotocol/services#4064
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.