Skip to content

Allow additional headers on underlying session configuration #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florianbuerger wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow additional headers on underlying session configuration #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c34032
Allow configuration of addtional HTTP headers in underlying session c…
florianbuerger Apr 11, 2018
09dbf43
Bump version
florianbuerger Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Digger.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "Digger"
s.version = "0.0.5"
s.version = "0.0.6"
s.summary = "A lightweight download framework that requires only one line of code to complete the file download task"
s.homepage = "https://github.com/cornerAnt/Digger"
s.license = { :type => "MIT", :file => "LICENSE" }
Expand Down
15 changes: 12 additions & 3 deletions Sources/DiggerManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,21 @@ open class DiggerManager:DiggerManagerProtocol {

let count = maxConcurrentTasksCount == 0 ? 1 : maxConcurrentTasksCount
session.invalidateAndCancel()
session = setupSession(allowsCellularAccess, count)
session = setupSession(allowsCellularAccess, count, additionalHTTPHeaders)
}
}

public var allowsCellularAccess: Bool = true {
didSet{
session.invalidateAndCancel()
session = setupSession(allowsCellularAccess, maxConcurrentTasksCount)
session = setupSession(allowsCellularAccess, maxConcurrentTasksCount, additionalHTTPHeaders)
}
}

public var additionalHTTPHeaders: [String: String] = [:] {
didSet {
session.invalidateAndCancel()
session = setupSession(allowsCellularAccess, maxConcurrentTasksCount, additionalHTTPHeaders)
}
}

Expand All @@ -90,6 +97,7 @@ open class DiggerManager:DiggerManagerProtocol {
let sessionConfiguration = URLSessionConfiguration.default
sessionConfiguration.allowsCellularAccess = allowsCellularAccess
sessionConfiguration.httpMaximumConnectionsPerHost = maxConcurrentTasksCount
sessionConfiguration.httpAdditionalHeaders = additionalHTTPHeaders
session = URLSession(configuration: sessionConfiguration, delegate: diggerDelegate, delegateQueue: delegateQueue)
}

Expand All @@ -100,11 +108,12 @@ open class DiggerManager:DiggerManagerProtocol {



private func setupSession(_ allowsCellularAccess:Bool ,_ maxDownloadTasksCount:Int ) -> URLSession{
private func setupSession(_ allowsCellularAccess:Bool ,_ maxDownloadTasksCount:Int, _ additionalHTTPHeaders:[String:String] ) -> URLSession{
diggerDelegate = DiggerDelegate()
let sessionConfiguration = URLSessionConfiguration.default
sessionConfiguration.allowsCellularAccess = allowsCellularAccess
sessionConfiguration.httpMaximumConnectionsPerHost = maxDownloadTasksCount
sessionConfiguration.httpAdditionalHeaders = additionalHTTPHeaders
let session = URLSession(configuration: sessionConfiguration, delegate: diggerDelegate, delegateQueue: delegateQueue)

return session
Expand Down