Added DataTypeIdentifier to ValidationFlow#212
Open
raphael-goetz wants to merge 2 commits intomainfrom
Open
Conversation
Taucher2003
requested changes
Feb 20, 2026
Taucher2003
reviewed
Feb 20, 2026
| @@ -16,8 +16,8 @@ message ValidationFlow { | |||
| // All custom data types used in this flow | |||
| repeated shared.ExecutionDataType data_types = 4; | |||
Member
There was a problem hiding this comment.
All the rule objects only contain a string for the data_type_identifier. I think we also need to adjust them to contain shared.DataTypeIdentifier instead. That also means that we could drop the separation between definition and execution for those rules
Member
Author
There was a problem hiding this comment.
Alright, but rules like InputTypes, ReturnType and ParentType are still not needed in this context?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #210