-
Notifications
You must be signed in to change notification settings - Fork 12
Introduce picker component #3908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FadhlanR
wants to merge
9
commits into
main
Choose a base branch
from
cs-10101-picker-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,565
−2
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
798b51f
Introduce picker component
FadhlanR 11b1e12
Update usage
FadhlanR f60a5a0
Update css
FadhlanR 7d3541f
lint fix
FadhlanR 2699799
Remove research.md
FadhlanR a635ba8
Merge branch 'main' into cs-10101-picker-component
FadhlanR 1b5a9c6
Update the select all behavior
FadhlanR 6abedb5
Select all
FadhlanR c1ad1b1
Address feedback
FadhlanR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
packages/boxel-ui/addon/src/components/picker/before-options-with-search.gts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| import { action } from '@ember/object'; | ||
| import Component from '@glimmer/component'; | ||
| import type { Select } from 'ember-power-select/components/power-select'; | ||
|
|
||
| import BoxelInput from '../input/index.gts'; | ||
| import type { PickerOption } from './index.gts'; | ||
|
|
||
| export interface BeforeOptionsWithSearchSignature { | ||
| Args: { | ||
| extra?: { | ||
| filterOptions?: ( | ||
| options: PickerOption[], | ||
| searchTerm: string, | ||
| ) => PickerOption[]; | ||
| onSearchTermChange?: (term: string) => void; | ||
| searchPlaceholder?: string; | ||
| searchTerm?: string; | ||
| }; | ||
| select: Select; | ||
| }; | ||
| } | ||
|
|
||
| export default class PickerBeforeOptionsWithSearch extends Component<BeforeOptionsWithSearchSignature> { | ||
| get searchTerm() { | ||
| return this.args.extra?.searchTerm || ''; | ||
| } | ||
|
|
||
| get searchPlaceholder() { | ||
| return this.args.extra?.searchPlaceholder || 'search for a realm'; | ||
| } | ||
|
|
||
| @action | ||
| updateSearchTerm(value: string) { | ||
| this.args.extra?.onSearchTermChange?.(value); | ||
| } | ||
|
|
||
| <template> | ||
| <div class='picker-before-options' data-test-boxel-picker-before-options> | ||
| <div class='picker-before-options__search' data-test-boxel-picker-search> | ||
| <BoxelInput | ||
| @type='search' | ||
| @value={{this.searchTerm}} | ||
| @onInput={{this.updateSearchTerm}} | ||
| @placeholder={{this.searchPlaceholder}} | ||
| class='picker-before-options__search-input' | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
||
| <style scoped> | ||
| .picker-before-options { | ||
| background-color: var(--boxel-light); | ||
| padding: 0 var(--boxel-sp-2xs); | ||
| } | ||
|
|
||
| .picker-before-options__search { | ||
| --boxel-input-search-color: var(--boxel-dark); | ||
| --boxel-input-search-background-color: transparent; | ||
| --icon-full-length: var(--boxel-icon-xs); | ||
| padding: 0 var(--boxel-sp-2xs); | ||
| } | ||
|
|
||
| .picker-before-options__search :deep(.input-container) { | ||
| --icon-full-length: var(--boxel-icon-xs); | ||
| } | ||
|
|
||
| .picker-before-options__search :deep(.search-icon) { | ||
| color: var(--boxel-dark); | ||
| height: 14px; | ||
| width: 14px; | ||
| } | ||
|
|
||
| .picker-before-options__search :deep(.search) { | ||
| padding-left: calc(var(--boxel-icon-xs) + var(--boxel-sp-2xs)); | ||
| } | ||
|
|
||
| .picker-before-options__search-input { | ||
| width: 100%; | ||
| border: none; | ||
| } | ||
|
|
||
| .picker-before-options__search-input:focus-visible { | ||
| outline: none; | ||
| } | ||
| </style> | ||
| </template> | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a custom
@dropdownClassis provided, the defaultboxel-multi-select__dropdownclass is replaced rather than combined. The base dropdown styles (box shadow, list reset/padding, option layout, z-index) are scoped to.boxel-multi-select__dropdownlater in the same file, so any custom dropdown (e.g. the new Picker’sboxel-picker__dropdown) will lose those base styles. This will change dropdown rendering (bulleted lists, missing padding/shadow, z-index) in any consumer that sets a custom class. Consider concatenating the default class with the custom class (like the Select component does) so custom dropdowns keep the base styling.Useful? React with 👍 / 👎.