-
-
Notifications
You must be signed in to change notification settings - Fork 659
feat: add py_zipapp_binary and test rules for zipapp support #3539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
149a840
basic impl
rickeylev a95377e
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev 1f22bdc
disable test pre-bazel 8
rickeylev 9328fbe
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev adb589f
add bazel 7 support
rickeylev 8ced1db
make test support workspace mode
rickeylev 5dbfab4
cleanup
rickeylev 89b438a
basic impl of config_settings attr
rickeylev 5ae496e
add missing bzl deps
rickeylev 3518a8b
format code
rickeylev b23f452
disable buildifier warning
rickeylev 6528660
fix case when venv is none
rickeylev 4046f98
add system_python test case
rickeylev a41b4fc
handle venv none in create_executable
rickeylev f6a3324
make zipapp transition set build zip to false
rickeylev e3b223d
try setting command_line_option:build_python_zip=false
rickeylev 895d21b
add cli:build_python_zip to transition outputs
rickeylev 678ea62
use correct type for cli:build_python_zip
rickeylev 5cdfd85
disable windows for zipapp tests
rickeylev cf2daa5
trying to debug windows
rickeylev ce0bb07
run fewer presubmits
rickeylev f1dd5fc
fix missing symbol loads
rickeylev 22387dc
add missing bzl dep, skip BCR test
rickeylev 3274d73
undo anti-zipper debug logic
rickeylev 9946c2e
improving test error reporting
rickeylev a7cca04
write bytes, not text, to avoid windows-specific line endings
rickeylev 860f561
re enable all presubmits
rickeylev 0df803f
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev d9a0f5f
debug logic for RBE
rickeylev a8d9bd0
more rbe debugging
rickeylev 0209bb8
make visible_for_testing a flag, more debug print
rickeylev 716c45c
try declare_symlink instead of declare_file
rickeylev 06af34a
undo declare_symlink; doesnt work with symlink(target_file)
rickeylev 702794f
maybe found RBE solution?
rickeylev f62f485
undo more presubmit debug
rickeylev 0e244bf
switch to bool_flag, remove extra escape
rickeylev d71691a
remove extraneous trap in shell bootstrap
rickeylev ad51589
remove defunct maybe_builtin_build_python_zip
rickeylev 1d2e8c9
add exec_runtime field, cleanup debug code
rickeylev d4a6ca2
add exec_runtime to changelog
rickeylev 01d52a6
fix null check in exec toolchain rule
rickeylev eba18ed
cleanup: doc new fields, remove debug from presubmit, changelog fixes
rickeylev bd28f94
handle arguments=None in actions_run
rickeylev badc4ef
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev 31e003b
add comment about window support
rickeylev d6a7ab6
move zipapp tools to tools/private
rickeylev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.