Skip to content

hotfix: add tutecnicoweb.com footer credit#46

Merged
baezor merged 1 commit intomainfrom
hotfix/footer-tutecnicoweb-credit
Feb 18, 2026
Merged

hotfix: add tutecnicoweb.com footer credit#46
baezor merged 1 commit intomainfrom
hotfix/footer-tutecnicoweb-credit

Conversation

@baezor
Copy link
Owner

@baezor baezor commented Feb 18, 2026

Summary

  • Adds a "Created by tutecnicoweb.com" credit line to the site footer
  • Fully translated: English ("Created by") and Spanish ("Creado por")
  • Uses the existing i18n system via a new footer.createdBy translation key

Test plan

  • Verify footer credit appears on English pages
  • Verify footer credit appears on Spanish (/es/) pages
  • Confirm link opens tutecnicoweb.com in a new tab

@baezor baezor merged commit cf87a9a into main Feb 18, 2026
1 of 2 checks passed
@claude
Copy link

claude bot commented Feb 18, 2026

Code Review

Summary

This is a small, focused change that adds a footer credit to tutecnicoweb.com with proper i18n support. The implementation is clean and consistent with existing codebase patterns. A few items worth addressing.


Issues

1. Missing accessible label on external link (Accessibility)

The link to tutecnicoweb.com opens in a new tab but does not communicate this to screen reader users. The sr-only class is already defined in Footer.astro and can be reused.

Suggested fix:

<a href="https://tutecnicoweb.com/" target="_blank" rel="noopener noreferrer">
  tutecnicoweb.com<span class="sr-only"> (opens in new tab)</span>
</a>

Add a corresponding i18n key (e.g., footer.newTab) for both en and es so the hidden text is also translated.


2. Stacked opacity reduces contrast below WCAG threshold (CSS / Accessibility)

.footer-content already sets opacity: 0.8 on the parent container. .footer-credit then adds opacity: 0.7, making the effective rendered opacity ~0.56 of the base text color. At font-size: 0.8rem this compounded reduction is likely to fail WCAG 2.1 AA contrast (4.5:1 for small text).

Suggested fix: Remove opacity from .footer-credit and rely on the parent's existing opacity: 0.8, or use a single explicit color value instead of layering opacities.


Minor Suggestions

3. Trailing slash in href

The href is https://tutecnicoweb.com/. Not a functional concern — just worth confirming this is the canonical URL the site owner prefers.


What's Done Well

  • Correct rel="noopener noreferrer" on the external link — good security hygiene.
  • Translation key follows the established namespace.key naming convention (footer.createdBy).
  • Both en and es translations are provided.
  • New CSS class is scoped properly inside the component <style> block.
  • Placement in the i18n file is consistent with neighbouring footer.* keys.

Verdict

Approve with suggestions — the two accessibility/contrast issues should be addressed before merge, but the overall implementation is solid and correctly follows the existing i18n and styling patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant