Skip to content

fix(iceberg): normalize float/double stats before encoding #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parisni wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −6
Open

fix(iceberg): normalize float/double stats before encoding #798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergColumnStatsConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ public Metrics toIceberg(Schema schema, long totalRowCount, List<ColumnStat> fie
valueCounts.put(fieldId, columnStats.getNumValues());
nullValueCounts.put(fieldId, columnStats.getNumNulls());
Type fieldType = icebergField.type();
if (columnStats.getRange().getMinValue() != null) {
lowerBounds.put(
fieldId, Conversions.toByteBuffer(fieldType, columnStats.getRange().getMinValue()));
Object minValue = normalizeStatValue(fieldType, columnStats.getRange().getMinValue());
if (minValue != null) {
lowerBounds.put(fieldId, Conversions.toByteBuffer(fieldType, minValue));
}
if (columnStats.getRange().getMaxValue() != null) {
upperBounds.put(
fieldId, Conversions.toByteBuffer(fieldType, columnStats.getRange().getMaxValue()));
Object maxValue = normalizeStatValue(fieldType, columnStats.getRange().getMaxValue());
if (maxValue != null) {
upperBounds.put(fieldId, Conversions.toByteBuffer(fieldType, maxValue));
}
});
return new Metrics(
Expand Down Expand Up @@ -130,4 +130,18 @@ private Object convertFromIcebergValue(Type fieldType, ByteBuffer value) {
}
return convertedValue;
}

private Object normalizeStatValue(Type fieldType, Object value) {
if (value == null || !(value instanceof Number)) {
return value;
}
switch (fieldType.typeId()) {
case FLOAT:
return ((Number) value).floatValue();
case DOUBLE:
return ((Number) value).doubleValue();
default:
return value;
}
}
}