Skip to content

feat: extract comments from avro schema #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parisni wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: extract comments from avro schema #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions xtable-core/src/main/java/org/apache/xtable/avro/AvroSchemaConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,19 @@ private InternalSchema toInternalSchema(
List<InternalField> subFields = new ArrayList<>(schema.getFields().size());
for (Schema.Field avroField : schema.getFields()) {
IdMapping idMapping = fieldNameToIdMapping.get(avroField.name());
String fieldDoc = avroField.doc();
if (fieldDoc == null) {
fieldDoc = avroField.getProp("comment");
}
InternalSchema subFieldSchema =
toInternalSchema(
avroField.schema(),
SchemaUtils.getFullyQualifiedPath(parentPath, avroField.name()),
getChildIdMap(idMapping));
Object defaultValue = getDefaultValue(avroField);
if (fieldDoc != null && subFieldSchema.getComment() == null) {
subFieldSchema = InternalSchema.builderFrom(subFieldSchema).comment(fieldDoc).build();
}
subFields.add(
InternalField.builder()
.parentPath(parentPath)
Expand Down