Macro image index?

[Makataui]

Hey,

As someone working with WSIs and properietary formats all the time (and millions of slides now) and with hundreds of pathologists, love the work going on here - really appreciate all the effort that gets put into libraries like this as it's building towards having more community tools that can convert between formats and is a nice addition to libraries like OpenSlide, TIFFFIle, PyDicom, the more foundational tools like VIPS, etc and then all the OME and ImageJ stuff and the rest of the imaging community that have been spectacular.

Just a small question - was spotted by a team member when we were exploring the library (so no credit to me!) when we were looking at how you return associated images like labels and all - but isn't the following line meant to have macro_image_index, not label_image_index:

const isyntax_image_t* libisyntax_get_macro_image(const isyntax_t* isyntax) { return isyntax->images + isyntax->label_image_index; }

I assume you'd want to return the macro/preview image in this case for the WSI, not the label image, so would need that index instead.

Here's the referenced line in question that was spotted:

libisyntax/src/libisyntax.c

Lines 260 to 262 in 049b90b

	const isyntax_image_t* libisyntax_get_macro_image(const isyntax_t* isyntax) {
	return isyntax->images + isyntax->label_image_index;
	}

Obviously directly above it, you have your get for the label image:

libisyntax/src/libisyntax.c

Lines 256 to 258 in 049b90b

	const isyntax_image_t* libisyntax_get_label_image(const isyntax_t* isyntax) {
	return isyntax->images + isyntax->label_image_index;
	}

Happy to report in a standard format, just wanted to check - apologies if I've misunderstood as we read this through.

[Falcury]

@Makataui Thank you, good catch! I fixed it in dac00dc.

I guess that it wasn't noticed by anyone else up until now because both libisyntax_get_macro_image() and libisyntax_get_label_image() are actually not needed to get the contents of the label and macro images (so maybe they can be entirely removed?). These can be used instead:

isyntax_error_t libisyntax_read_label_image(isyntax_t* isyntax, int32_t* width, int32_t* height, uint32_t** pixels_buffer, int32_t pixel_format);
isyntax_error_t libisyntax_read_macro_image(isyntax_t* isyntax, int32_t* width, int32_t* height, uint32_t** pixels_buffer, int32_t pixel_format);
isyntax_error_t libisyntax_read_label_image_jpeg(isyntax_t* isyntax, uint8_t** jpeg_buffer, uint32_t* jpeg_size);
isyntax_error_t libisyntax_read_macro_image_jpeg(isyntax_t* isyntax, uint8_t** jpeg_buffer, uint32_t* jpeg_size);