assert() or ASSERT()?

[Falcury]

Right now, I'm using a custom ASSERT() defined in common.h.

But if everyone prefers using the standard assert(), we could change it to that everywhere.

[jonasteuwen]

What’s the reason to have your own assert()?

[Falcury]

For Slidescape, mainly so it would trigger my own fatal error procedure I've been using (panic()) and it gives me control over setting breakpoints and the like. But it seems the normal assert() also does the job well enough.

[jonasteuwen]

If it does, I'd propose to change it. (I'm now working on getting a proper python wrapper, so starting to revisit all this...)

[Falcury]

Ok, agreed.

[Falcury]

I tried to make the change, but now when I use the regular assert() I can't get the debugger to break on failed assertions anymore (currently using CLion on Windows). Because I rely on breaking on assertion failures for debugging, I think I should leave the current ASSERT() in place until I know how to fix this.