From 32288e2d6b589fd6e7160e5fc6b3c401889aaccb Mon Sep 17 00:00:00 2001 From: lupaglio <36077212+lupaglio@users.noreply.github.com> Date: Fri, 2 Feb 2018 23:17:10 +0100 Subject: [PATCH 1/2] Added the isXiaomiRedmiNote4 variable Useful to identify the model Xiaomi Redmi Note 4/4X (codename mido) --- .../almalence/opencam/cameracontroller/CameraController.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/com/almalence/opencam/cameracontroller/CameraController.java b/src/com/almalence/opencam/cameracontroller/CameraController.java index a2772a0e..12eb7b4b 100644 --- a/src/com/almalence/opencam/cameracontroller/CameraController.java +++ b/src/com/almalence/opencam/cameracontroller/CameraController.java @@ -233,6 +233,8 @@ public class CameraController implements Camera.PictureCallback, Camera.AutoFocu public static boolean isPixel = Build.MANUFACTURER.toLowerCase().replace(" ", "").contains("google") && Build.MODEL.toLowerCase().replace(" ", "").contains("pixel"); + public static boolean isXiaomiRedmiNote4 = Build.MODEL.toLowerCase(Locale.US).replace(" ", "").contains("redminote4"); + public static boolean motozChangeResolution = false; // Android camera parameters constants From 351fd85b11f532981a1572b0c8762b37eaf38cde Mon Sep 17 00:00:00 2001 From: lupaglio <36077212+lupaglio@users.noreply.github.com> Date: Fri, 2 Feb 2018 23:42:46 +0100 Subject: [PATCH 2/2] Don't apply CameraParameters.SCENE_MODE_NIGHT if isXiaomiRedmiNote4 Xiaomi Redmi Note 4/4X always apply "Auto Flash" if in SCENE_MODE_NIGHT, so we don't apply it. --- src/com/almalence/plugins/capture/night/NightCapturePlugin.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/almalence/plugins/capture/night/NightCapturePlugin.java b/src/com/almalence/plugins/capture/night/NightCapturePlugin.java index 3adc4f57..90524a6c 100755 --- a/src/com/almalence/plugins/capture/night/NightCapturePlugin.java +++ b/src/com/almalence/plugins/capture/night/NightCapturePlugin.java @@ -395,7 +395,7 @@ public void setupCameraParameters() // exlude also LG G3 and some others modifications to prevent camera error in takePicture call. // FixMe: probably Nexus should not be excluded if using Camera2 interface if (sceneModes != null && CameraController.isModeAvailable(sceneModes, CameraParameters.SCENE_MODE_NIGHT) - && (!CameraController.isNexus && !CameraController.isG3) && !usingSuperMode) + && (!CameraController.isNexus && !CameraController.isG3 && !CameraController.isXiaomiRedmiNote4) && !usingSuperMode) { CameraController.setCameraSceneMode(CameraParameters.SCENE_MODE_NIGHT); ApplicationScreen.instance.setSceneModePref(CameraParameters.SCENE_MODE_NIGHT);