From 13ec391313b5f6e54132ade61e844d40c34d2417 Mon Sep 17 00:00:00 2001
From: Benjamin Willig <benjamin.willig@acsone.eu>
Date: Wed, 24 Jul 2024 10:56:46 +0200
Subject: [PATCH] [FIX?] preserve translate values when updating a field/model
 when its inherited

When inheriting from a field and changing its attributes, Odoo will override the translatable
fields of ir.model and ir.model.fields, losing all of the translations. This commit preserve the old translations when the term we want to use is the same that we find in english lang
---
 odoo/addons/base/models/ir_model.py | 62 +++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/odoo/addons/base/models/ir_model.py b/odoo/addons/base/models/ir_model.py
index 107bd1bead667..5e0485af7e385 100644
--- a/odoo/addons/base/models/ir_model.py
+++ b/odoo/addons/base/models/ir_model.py
@@ -142,6 +142,8 @@ def identity(val):
         return val
 
     def jsonify(val):
+        if isinstance(val, dict):
+            return Json(val)
         return Json({'en_US': val}) if val is not None else val
 
     wrappers = [(jsonify if model._fields[fname].translate else identity) for fname in fnames]
@@ -366,6 +368,33 @@ def name_create(self, name):
         }
         return self.create(vals).name_get()[0]
 
+    def _preserve_model_translate_params(self, model):
+        fields_to_keep = {
+            "name": model._description,
+        }
+        table_name = "ir_model"
+        self._cr.execute(
+            """
+            SELECT %s FROM %s
+            WHERE
+            model = %s
+            """,
+            (
+                psycopg2.extensions.AsIs(','.join(fields_to_keep)),
+                psycopg2.extensions.AsIs(table_name),
+                model._name,
+            ),
+        )
+        result = self._cr.dictfetchall()
+        translatable_values = {}
+        if result:
+            row = result[0]
+            for fname, default_value in fields_to_keep.items():
+                value = row.get(fname)
+                if value and default_value == value.get('en_US'):
+                    translatable_values[fname] = value
+        return translatable_values
+
     def _reflect_model_params(self, model):
         """ Return the values to write to the database for the given model. """
         return {
@@ -375,6 +404,7 @@ def _reflect_model_params(self, model):
             'info': next(cls.__doc__ for cls in self.env.registry[model._name].mro() if cls.__doc__),
             'state': 'manual' if model._custom else 'base',
             'transient': model._transient,
+            **self._preserve_model_translate_params(model),
         }
 
     def _reflect_models(self, model_names):
@@ -1021,6 +1051,37 @@ def name_get(self):
             res.append((field.id, '%s (%s)' % (field.field_description, field.model)))
         return res
 
+    def _preserve_field_translate_params(self, field):
+        fields_to_keep = {
+            "field_description": field.string,
+            "help": field.help,
+        }
+        table_name = "ir_model_fields"
+        self._cr.execute(
+            """
+            SELECT %s FROM %s
+            WHERE
+            name = %s
+            AND
+            model = %s
+            """,
+            (
+                psycopg2.extensions.AsIs(','.join(fields_to_keep)),
+                psycopg2.extensions.AsIs(table_name),
+                field.name,
+                field.model_name,
+            ),
+        )
+        result = self._cr.dictfetchall()
+        translatable_values = {}
+        if result:
+            row = result[0]
+            for fname, default_value in fields_to_keep.items():
+                value = row.get(fname)
+                if value and default_value == value.get('en_US'):
+                    translatable_values[fname] = value
+        return translatable_values
+
     def _reflect_field_params(self, field, model_id):
         """ Return the values to write to the database for the given field. """
         return {
@@ -1046,6 +1107,7 @@ def _reflect_field_params(self, field, model_id):
             'relation_table': field.relation if field.type == 'many2many' else None,
             'column1': field.column1 if field.type == 'many2many' else None,
             'column2': field.column2 if field.type == 'many2many' else None,
+            **self._preserve_field_translate_params(field)
         }
 
     def _reflect_fields(self, model_names):