-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Context
PR #280 review identified that the membership history endpoint returns a SearchResult wrapper but internally uses a different pattern than other search endpoints. Per ADR-019, all list/search responses should use SearchResult consistently.
Current Behavior
The /Group/{id}/membership-history endpoint:
- Builds history entries from
spp.group.membershiprecords in Python - Returns a
SearchResultwrapper viacreate_search_result() - Each entry is a plain dict, not a typed schema
Desired Behavior
- Define a
MembershipHistoryEntryschema (or similar) - Ensure the response structure is consistent with ADR-019
SearchResultconventions - Consider whether
GroupMembershipBundleschema should be replaced with standardSearchResult
Scope
This is a larger refactoring that affects:
spp_api_v2/schemas/- schema definitionsspp_api_v2/routers/group.py- endpoint response modelspp_api_v2/services/group_service.py- return types- Tests
Source
Gemini code review finding on PR #280, triaged as valid but deferred to separate PR.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request