Tests Failing Due to Streamlit Version Update

[jcharkow]

Seems that the unit tests are now failing because of a streamlit version update.

See here for more details:
https://github.com/OpenMS/streamlit-template/actions/runs/14070183348/job/39474851478?pr=209

[jcharkow]

Would be best to update the codebase to work with the latest streamlit version and require the latest streamlit version in the requirements.txt file

[Leandro1302]

@jcharkow I think that the calc_md5 function has been removed from streamlit.source_util, right?
If so, I could change the code using the module hashlib to find the hash.
Let me know if that would be ok !

[ketan1406]

Hi there @jcharkow, I believe the calc_md5 still exists in the Streamlit codebase, the problem I am facing upon testing is with the streamlit-source_util module, I am currently looking into this issue, I can take this on if you like.

Edit: I looked into the issue further, the module imports for functions calc_md5, get_pages and _on_pages_changed have been refactored, although calc_md5 and get_pages are pretty intuitively refactored, the _on_pages_changed function has been replaced completely. I am currently working on looking up the older releases of _on_pages_changed to understand its functionality.

[jcharkow]

@ketan1406 feel free to work on this issue. Yes I think likely refactoring occured sounds like you are on the right track. I am not sure how exactly it was refactored.

[jcharkow]

@jcharkow I think that the calc_md5 function has been removed from streamlit.source_util, right?
If so, I could change the code using the module hashlib to find the hash.
Let me know if that would be ok !

Sorry I think @ketan1406 was on this first so I will let them tackle this issue.

[Leandro1302]

@jcharkow I think that the calc_md5 function has been removed from streamlit.source_util, right?
If so, I could change the code using the module hashlib to find the hash.
Let me know if that would be ok !

Sorry I think @ketan1406 was on this first so I will let them tackle this issue.

It’s ok sir, I’m sorry because it was my mistake to just stop and look that the function is no longer in source_util. In fact looking more closely I just saw that calc_md5 for example has simply been moved to util.

[ketan1406]

@ketan1406 feel free to work on this issue. Yes I think likely refactoring occured sounds like you are on the right track. I am not sure how exactly it was refactored.

Yes @jcharkow I am currently working on the issue, the issue is with all the functions that were earlier in source_util and the changes are relatively new so they do not have a lot of documentation about them, I should be able to figure this out in some time, meanwhile I have an open PR #206, it deals with new logo incorporation for the windows installer and st webpage, should I commit my changes to the same PR and edit the PR? If not, kindly review the PR as the changes are minimal and once they get merged, I can raise another PR.

[t0mdavid-m]

Looks like this function was moved to streamlit.source @ketan1406.

[ketan1406]

@t0mdavid-m I believe currently for the streamlit version 1.44.0 there is no streamlit.source module, instead calc_md5 has moved to streamlit.util but the problem doesn't end there, the get_pages has been moved to streamlit.runtime.pages_manager (which cannot be accesed directly) and _on_pages_changed has been removed completely. Streamlit currenlty relies on the MPAv2 to control state and navigation for multipage apps, the changes for the above were made last month as you can see in their PR #10276 on their Github, its taking me longer than I had expected earlier, any tips would be much appreciated, I am currently diving into streamlit code to understand the changes made.

[namrathavpatil]

I apologize for not checking to see that someone was already working on this issue. I understand that @ketan1406 is the one responsible, and I truly appreciate all the hard work done to resolve it. I also worked on the issue and regret not realizing it was already being handled. Please check the PR: #222. Thank you for your understanding and contributions.

[ketan1406]

Hi @namrathavpatil I noticed you have used certain internal runtime modules for replacing the syntax from previous versions, I would recommend you test your the project workflows, as I had gotten an error for using these exact same libraries saying that they are not stable because they were internal methods, if everything works fine for you, I would be more than happy for your PR to be merged.