When a player lost his/her link, it's not possible for the other players to go to the next round.

[sydseter]

Problem:

When playing at copi.owasp.org.
When a player lost his/her link, it's not possible for the other players to go to the next round.

Solution:

Always have the possibility to go to the next round by having the next round button visible.

[Suresh-Krishna-P]

Hello @sydseter ,

I’d like to work on this issue and have outlined a proposed implementation strategy below. I’d appreciate your feedback.

I've analyzed the codebase and identified the issue with the next round button being disabled when players lose their connection.

Proposed Solution

Remove the conditional disabling of the Next Round button to allow other players to continue the game when someone loses their connection.

File to modify: copi.owasp.org/lib/copi_web/live/player_live/show.html.heex

Change: Remove the class and disabled attributes that depend on round_open?(@game):

<!-- Before -->
<.primary_button class={if round_open?(@game) do "bg-zinc-900/15 pointer-events-none" end} disabled={round_open?(@game)} phx-click="next_round" phx-value-game_id={@game.id}>

<!-- After -->
<.primary_button phx-click="next_round" phx-value-game_id={@game.id}>

Rationale: The server-side next_round handler in copi.owasp.org/lib/copi_web/live/player_live/show.ex already has logic to handle cases where not all players have played (lines 24-28). It safely ignores requests to advance rounds when players are still to play, making the client-side disabling unnecessary and problematic for disconnected players.

This change ensures that games can continue even when some players lose their connection, while maintaining the existing server-side safety checks.

If you’re okay with this approach, I’m happy to open a PR.

[sydseter]

@Suresh-Krishna-P I have assigned you.

Remember to add yourself to the alphabetical contributor list: https://github.com/OWASP/cornucopia/blob/master/cornucopia.owasp.org/data/website/pages/about/en/index.md

[Suresh-Krishna-P]

Thank You @sydseter for assigning this issue to me and I have enclosed my PR.
I have added myself to the alphabetical contributor list.