From aa43624e8a78b3f368f9dbebebcf290acb657471 Mon Sep 17 00:00:00 2001 From: Mohajiro Date: Wed, 2 Jul 2025 15:19:25 +0200 Subject: [PATCH 1/4] [ADD] project_task_stage_change_restriction: new module MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Ensure that only the assigned user, project manager, or users in allowed groups can change a task’s stage, improving access control and enforcing project workflows. Task: 4812 --- .../README.rst | 123 ++++++++ .../__init__.py | 4 + .../__manifest__.py | 21 ++ .../data/demo_project_task_stage.xml | 53 ++++ .../i18n/.empty | 0 .../project_task_stage_change_restriction.pot | 119 ++++++++ .../models/__init__.py | 5 + .../models/project_task.py | 78 +++++ .../models/project_task_type.py | 37 +++ .../readme/CONFIGURE.md | 16 + .../readme/CONTEXT.md | 1 + .../readme/CONTRIBUTORS.md | 4 + .../readme/DESCRIPTION.md | 1 + .../readme/USAGE.md | 2 + .../readme/newsfragments/.gitkeep | 0 .../static/description/icon.png | Bin 0 -> 10254 bytes .../static/description/index.html | 124 ++++++++ .../tests/__init__.py | 4 + .../tests/test_stage_change_restriction.py | 277 ++++++++++++++++++ .../views/project_task_stage_views.xml | 27 ++ 20 files changed, 896 insertions(+) create mode 100644 project_task_stage_change_restriction/README.rst create mode 100644 project_task_stage_change_restriction/__init__.py create mode 100644 project_task_stage_change_restriction/__manifest__.py create mode 100644 project_task_stage_change_restriction/data/demo_project_task_stage.xml create mode 100644 project_task_stage_change_restriction/i18n/.empty create mode 100644 project_task_stage_change_restriction/i18n/project_task_stage_change_restriction.pot create mode 100644 project_task_stage_change_restriction/models/__init__.py create mode 100644 project_task_stage_change_restriction/models/project_task.py create mode 100644 project_task_stage_change_restriction/models/project_task_type.py create mode 100644 project_task_stage_change_restriction/readme/CONFIGURE.md create mode 100644 project_task_stage_change_restriction/readme/CONTEXT.md create mode 100644 project_task_stage_change_restriction/readme/CONTRIBUTORS.md create mode 100644 project_task_stage_change_restriction/readme/DESCRIPTION.md create mode 100644 project_task_stage_change_restriction/readme/USAGE.md create mode 100644 project_task_stage_change_restriction/readme/newsfragments/.gitkeep create mode 100644 project_task_stage_change_restriction/static/description/icon.png create mode 100644 project_task_stage_change_restriction/static/description/index.html create mode 100644 project_task_stage_change_restriction/tests/__init__.py create mode 100644 project_task_stage_change_restriction/tests/test_stage_change_restriction.py create mode 100644 project_task_stage_change_restriction/views/project_task_stage_views.xml diff --git a/project_task_stage_change_restriction/README.rst b/project_task_stage_change_restriction/README.rst new file mode 100644 index 0000000000..60bd9c9b50 --- /dev/null +++ b/project_task_stage_change_restriction/README.rst @@ -0,0 +1,123 @@ +.. image:: https://odoo-community.org/readme-banner-image + :target: https://odoo-community.org/get-involved?utm_source=readme + :alt: Odoo Community Association + +===================================== +Project Task Stage Change Restriction +===================================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:70428b68fa49a42f600173b5497b2a3cab2b78eca3ac7ce36d711878aa841f88 + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproject-lightgray.png?logo=github + :target: https://github.com/OCA/project/tree/16.0/project_task_stage_change_restriction + :alt: OCA/project +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_stage_change_restriction + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/project&target_branch=16.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module allows specifying which users or groups can move a task to a +specific stage. + +**Table of contents** + +.. contents:: + :local: + +Use Cases / Context +=================== + +There may be cases where you want to prevent certain users from moving a +task into specific stages. For example, developers can move tasks to the +"Review" stage, but only a project manager can move a task to the "Done" +or "Cancel" stages. + +Configuration +============= + +The **Task Stages** menu is only visible when Odoo is in developer mode. +Please turn on developer mode before proceeding. + +Go to "Project > Configuration > Task Stages" and select or create a new +task stage. Configure the following fields in the "Stage Change +Restriction" group: + +- **Assigned Only** + If enabled, only users assigned to the task can move it into this + stage. +- **Project Manager** + If enabled, only the manager of the project this task belongs to can + move it. +- **Group Members** + Select groups whose members can move tasks into this stage. + +Please be advised, that selected conditions are evaluated using the "OR" +principle. So, a user should satisfy any of the selected conditions. + +NB: restrictions are not applied if a stage is being changed by a +superuser. + +Usage +===== + +| Try to move a task to a restricted stage. If your user doesn't satisfy + the stage-allowance conditions, the following access error will be + raised: +| "Sorry, you are not allowed to move the task '' into the + stage ''." + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* Cetmix + +Contributors +------------ + +Cetmix Ivan Sokolov Andrei Loukachov + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/project `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/project_task_stage_change_restriction/__init__.py b/project_task_stage_change_restriction/__init__.py new file mode 100644 index 0000000000..6f11353338 --- /dev/null +++ b/project_task_stage_change_restriction/__init__.py @@ -0,0 +1,4 @@ +# Copyright (C) 2025 Cetmix OÜ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import models diff --git a/project_task_stage_change_restriction/__manifest__.py b/project_task_stage_change_restriction/__manifest__.py new file mode 100644 index 0000000000..6bd07342a1 --- /dev/null +++ b/project_task_stage_change_restriction/__manifest__.py @@ -0,0 +1,21 @@ +# Copyright (C) 2025 Cetmix OÜ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +{ + "name": "Project Task Stage Change Restriction", + "summary": "Restrict project task stage", + "version": "16.0.1.0.0", + "category": "Project", + "author": "Odoo Community Association (OCA), Cetmix", + "license": "AGPL-3", + "website": "https://github.com/OCA/project", + "depends": ["project"], + "data": [ + "views/project_task_stage_views.xml", + ], + "demo": [ + "data/demo_project_task_stage.xml", + ], + "installable": True, + "application": False, +} diff --git a/project_task_stage_change_restriction/data/demo_project_task_stage.xml b/project_task_stage_change_restriction/data/demo_project_task_stage.xml new file mode 100644 index 0000000000..5ccbe0910a --- /dev/null +++ b/project_task_stage_change_restriction/data/demo_project_task_stage.xml @@ -0,0 +1,53 @@ + + + + + Free + 5 + + + Assigned Only + 10 + 1 + + + Project Manager Only + 15 + 1 + + + Project Users Only + 20 + + + + + Restricted Demo Project + + + + + + Dev Task + + + + + + PM Task + + + + + diff --git a/project_task_stage_change_restriction/i18n/.empty b/project_task_stage_change_restriction/i18n/.empty new file mode 100644 index 0000000000..e69de29bb2 diff --git a/project_task_stage_change_restriction/i18n/project_task_stage_change_restriction.pot b/project_task_stage_change_restriction/i18n/project_task_stage_change_restriction.pot new file mode 100644 index 0000000000..331197acb6 --- /dev/null +++ b/project_task_stage_change_restriction/i18n/project_task_stage_change_restriction.pot @@ -0,0 +1,119 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * project_task_stage_change_restriction +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 16.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: \n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: project_task_stage_change_restriction +#: model:ir.model.fields,field_description:project_task_stage_change_restriction.field_project_task_type__allow_assigned_only +#: model:project.task.type,name:project_task_stage_change_restriction.demo_stage_assigned_only +msgid "Assigned Only" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,legend_blocked:project_task_stage_change_restriction.demo_stage_assigned_only +#: model:project.task.type,legend_blocked:project_task_stage_change_restriction.demo_stage_free +#: model:project.task.type,legend_blocked:project_task_stage_change_restriction.demo_stage_group_only +#: model:project.task.type,legend_blocked:project_task_stage_change_restriction.demo_stage_pm_only +msgid "Blocked" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,name:project_task_stage_change_restriction.demo_stage_free +msgid "Free" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:ir.model.fields,field_description:project_task_stage_change_restriction.field_project_task_type__allow_group_ids +msgid "Group Members" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model_terms:ir.ui.view,arch_db:project_task_stage_change_restriction.view_project_task_type_form_restriction +msgid "If enabled, only the project manager can move tasks into this stage." +msgstr "" + +#. module: project_task_stage_change_restriction +#: model_terms:ir.ui.view,arch_db:project_task_stage_change_restriction.view_project_task_type_form_restriction +msgid "" +"If enabled, only users assigned to the task can move it into this stage." +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,legend_normal:project_task_stage_change_restriction.demo_stage_assigned_only +#: model:project.task.type,legend_normal:project_task_stage_change_restriction.demo_stage_free +#: model:project.task.type,legend_normal:project_task_stage_change_restriction.demo_stage_group_only +#: model:project.task.type,legend_normal:project_task_stage_change_restriction.demo_stage_pm_only +msgid "In Progress" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model_terms:ir.ui.view,arch_db:project_task_stage_change_restriction.view_project_task_type_form_restriction +msgid "Members of selected groups can move tasks into this stage." +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:ir.model.fields,field_description:project_task_stage_change_restriction.field_project_task_type__allow_project_manager +msgid "Project Manager" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,name:project_task_stage_change_restriction.demo_stage_pm_only +msgid "Project Manager Only" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,name:project_task_stage_change_restriction.demo_stage_group_only +msgid "Project Users Only" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,legend_done:project_task_stage_change_restriction.demo_stage_assigned_only +#: model:project.task.type,legend_done:project_task_stage_change_restriction.demo_stage_free +#: model:project.task.type,legend_done:project_task_stage_change_restriction.demo_stage_group_only +#: model:project.task.type,legend_done:project_task_stage_change_restriction.demo_stage_pm_only +msgid "Ready" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:project.project,name:project_task_stage_change_restriction.demo_project_restricted +msgid "Restricted Demo Project" +msgstr "" + +#. module: project_task_stage_change_restriction +#. odoo-python +#: code:addons/project_task_stage_change_restriction/models/project_task.py:0 +#, python-format +msgid "" +"Sorry, you are not allowed to move the task '%(task)s' into the stage " +"'%(stage)s'." +msgstr "" + +#. module: project_task_stage_change_restriction +#: model_terms:ir.ui.view,arch_db:project_task_stage_change_restriction.view_project_task_type_form_restriction +msgid "Stage Change Restriction" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:ir.model,name:project_task_stage_change_restriction.model_project_task +msgid "Task" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:ir.model,name:project_task_stage_change_restriction.model_project_task_type +msgid "Task Stage" +msgstr "" + +#. module: project_task_stage_change_restriction +#: model:project.project,label_tasks:project_task_stage_change_restriction.demo_project_restricted +msgid "Tasks" +msgstr "" diff --git a/project_task_stage_change_restriction/models/__init__.py b/project_task_stage_change_restriction/models/__init__.py new file mode 100644 index 0000000000..f4ceadc0b6 --- /dev/null +++ b/project_task_stage_change_restriction/models/__init__.py @@ -0,0 +1,5 @@ +# Copyright (C) 2025 Cetmix OÜ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import project_task_type +from . import project_task diff --git a/project_task_stage_change_restriction/models/project_task.py b/project_task_stage_change_restriction/models/project_task.py new file mode 100644 index 0000000000..e46770908d --- /dev/null +++ b/project_task_stage_change_restriction/models/project_task.py @@ -0,0 +1,78 @@ +# Copyright (C) 2025 Cetmix OÜ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import _, api, models +from odoo.exceptions import UserError + + +class ProjectTask(models.Model): + _inherit = "project.task" + + def _is_move_allowed(self, task, new_stage, user): + """Return True if **user** may move **task** into **new_stage** (OR-logic). + + OR-logic sequence: + 1. No restrictions on stage, or superuser → always True + 2. allow_assigned_only and user in task.user_ids + 3. allow_project_manager and user is project.manager_id + 4. allow_group_ids and user in allowed groups + """ + # unrestricted stage / super-user + if not new_stage or not new_stage._has_restrictions() or user._is_superuser(): + return True + + # Assigned Only + if new_stage.allow_assigned_only and user in task.user_ids: + return True + + # Project Manager: use the core alias `manager_id` + pm = getattr(task.project_id, "manager_id", task.project_id.user_id) + if new_stage.allow_project_manager and pm and user == pm: + return True + + # Group Members + if new_stage._user_in_allowed_group(user): + return True + + return False + + def _check_stage_restriction(self, vals): + """Raise UserError if current env-user is NOT allowed.""" + stage_id = vals.get("stage_id") + if not stage_id: + return True + + new_stage = self.env["project.task.type"].browse(stage_id) + if not new_stage: + return True + + for task in self: + if not self._is_move_allowed(task, new_stage, self.env.user): + raise UserError( + _( + "Sorry, you are not allowed to move the task " + "'%(task)s' into the stage '%(stage)s'." + ) + % {"task": task.display_name, "stage": new_stage.display_name} + ) + return True + + def write(self, vals): + """Override write() to enforce stage‐change restrictions.""" + # validate the user is allowed to move into a new stage + self._check_stage_restriction(vals) + return super().write(vals) + + @api.model_create_multi + def create(self, vals_list): + """Override create() to enforce stage restrictions on new tasks. + + :param vals_list: list of dicts of values for each record + :return: the newly created recordset + """ + recs = super().create(vals_list) + # validate once stage is definitely set + for rec in recs: + if rec.stage_id: + rec._check_stage_restriction({"stage_id": rec.stage_id.id}) + return recs diff --git a/project_task_stage_change_restriction/models/project_task_type.py b/project_task_stage_change_restriction/models/project_task_type.py new file mode 100644 index 0000000000..5520b18ac2 --- /dev/null +++ b/project_task_stage_change_restriction/models/project_task_type.py @@ -0,0 +1,37 @@ +# Copyright (C) 2025 Cetmix OÜ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import fields, models + + +class ProjectTaskType(models.Model): + _inherit = "project.task.type" + + allow_assigned_only = fields.Boolean(string="Assigned Only") + allow_project_manager = fields.Boolean(string="Project Manager") + allow_group_ids = fields.Many2many( + "res.groups", + "project_task_stage_allowed_group_rel", + "stage_id", + "group_id", + string="Group Members", + ) + + def _has_restrictions(self): + """Return *True* if **any** restriction flag / group is set.""" + self.ensure_one() + return bool( + self.allow_assigned_only + or self.allow_project_manager + or self.allow_group_ids + ) + + def _user_in_allowed_group(self, user): + """ + Return *True* when *user* belongs to ≥ 1 selected groups. + Empty group list → rule **not** applied. + """ + self.ensure_one() + if not self.allow_group_ids: + return False + return bool(self.allow_group_ids & user.groups_id) diff --git a/project_task_stage_change_restriction/readme/CONFIGURE.md b/project_task_stage_change_restriction/readme/CONFIGURE.md new file mode 100644 index 0000000000..95301f9007 --- /dev/null +++ b/project_task_stage_change_restriction/readme/CONFIGURE.md @@ -0,0 +1,16 @@ +The **Task Stages** menu is only visible when Odoo is in developer mode. +Please turn on developer mode before proceeding. + +Go to "Project > Configuration > Task Stages" and select or create a new task stage. +Configure the following fields in the "Stage Change Restriction" group: + +- **Assigned Only** + If enabled, only users assigned to the task can move it into this stage. +- **Project Manager** + If enabled, only the manager of the project this task belongs to can move it. +- **Group Members** + Select groups whose members can move tasks into this stage. + +Please be advised, that selected conditions are evaluated using the "OR" principle. So, a user should satisfy any of the selected conditions. + +NB: restrictions are not applied if a stage is being changed by a superuser. diff --git a/project_task_stage_change_restriction/readme/CONTEXT.md b/project_task_stage_change_restriction/readme/CONTEXT.md new file mode 100644 index 0000000000..1bdfa51183 --- /dev/null +++ b/project_task_stage_change_restriction/readme/CONTEXT.md @@ -0,0 +1 @@ +There may be cases where you want to prevent certain users from moving a task into specific stages. For example, developers can move tasks to the "Review" stage, but only a project manager can move a task to the "Done" or "Cancel" stages. diff --git a/project_task_stage_change_restriction/readme/CONTRIBUTORS.md b/project_task_stage_change_restriction/readme/CONTRIBUTORS.md new file mode 100644 index 0000000000..4c6060863c --- /dev/null +++ b/project_task_stage_change_restriction/readme/CONTRIBUTORS.md @@ -0,0 +1,4 @@ +Cetmix + Ivan Sokolov + Andrei Loukachov + \ No newline at end of file diff --git a/project_task_stage_change_restriction/readme/DESCRIPTION.md b/project_task_stage_change_restriction/readme/DESCRIPTION.md new file mode 100644 index 0000000000..95d4159b36 --- /dev/null +++ b/project_task_stage_change_restriction/readme/DESCRIPTION.md @@ -0,0 +1 @@ +This module allows specifying which users or groups can move a task to a specific stage. diff --git a/project_task_stage_change_restriction/readme/USAGE.md b/project_task_stage_change_restriction/readme/USAGE.md new file mode 100644 index 0000000000..f3346f1600 --- /dev/null +++ b/project_task_stage_change_restriction/readme/USAGE.md @@ -0,0 +1,2 @@ +Try to move a task to a restricted stage. If your user doesn't satisfy the stage-allowance conditions, the following access error will be raised: +"Sorry, you are not allowed to move the task '' into the stage ''." diff --git a/project_task_stage_change_restriction/readme/newsfragments/.gitkeep b/project_task_stage_change_restriction/readme/newsfragments/.gitkeep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/project_task_stage_change_restriction/static/description/icon.png b/project_task_stage_change_restriction/static/description/icon.png new file mode 100644 index 0000000000000000000000000000000000000000..1dcc49c24f364e9adf0afbc6fc0bac6dbecdeb11 GIT binary patch literal 10254 zcmbt)WmufcvhH9Zc!C8B?l8#UE&&o;gF7=g3=D(IAOS+K1lK^25Zv7%L4sRw_uvvF z*qyAk?>c**=lnR&y+1yw{;I3Hy6Ua2{<d0kcR+VvBo; zA_X`>;1;xAPL9rQqFxd#f5{a^zW*uaW+r3+U{|fRunu`GZhy$X z8_|Zi{zd#vIokczl8Xh*4Wi@i0+C?Rg1AB5VOEg8B>buLFCi~r5DPd2ED7QP2>^LO zKpr7+?*I1bPaFSLLEa0l2$tj*;u8Qtc=&(RUc*VK@ zjIN{I--GfO@vl+&r^eqy_BZ3dndN_PDzMc*W^!?dIsWAWU@LBjBg6^f4F6*!-hUYh zY$Xb}gF8b0%S1Ac@c%Rs()UCiEu3v6SiFE>h_!{gBb-H2{e=wB5o!YkT0>#LKZFw$ z?CuD0Gvfsb(|XbVxx0AL0%`gG2X+6|f;jiTHU9shtjoW-{2!| zMN*WuOj6elhD4zqgjNpX>F#JP{)hAbenX<+FPr>7jXM&q{|x+pbj8cU<=>Ej zWE1_%qoFVzDAZB%g@v<+1ud%<#2E~ML11jOV5pUZoXktGmzB38%te^i-3o9i$lge>z>tBcK|P2K0H9w{l#|i%$~egM)Ys{q>p<9yaE*%v2cy1wXE{AXqG1_b znfyg@Fq*e@yC)^(@$R*j^E;skyEM6pmL$1ctg*mWiWM&q1{nj>E^)Odw$RPr zhjesSk}k}@-e_%uZTy0t_*TJD&6%*HV0KH>xE@oBex6CL@`Ty3nH_2OF#M?6j(j|9 znRKGSfp3Q2i+|>}w?>8g$>r`|OcvG5r;p)z8DO8+O>EvYQ=_~`p}9!ReUEjUnNL@6 z+C*aoo67(sd|7QgW54@V9Y8PnBW$Q+7ZsRFA}Vj*viA!yWUfb!s*yJi6JKsXZCH4j z*B%nJpad-DDvJ8d>xrxkkh6A}i7V3nULqHCiG~|)YY6{NE3M}c^s#PQhzhsJUf^QW zR+F;up-dN*!)M1ZYl@d0HoqfVD2PNiQcPdzq4NDKO!8mUl{!t*ntBg_+-+lRlI0~Lr>5v!PiQj|hD7B-YFIs~6hIY*R6USZA zlb}=UxqxpSzIsL3pPmiuixCN|3LFBd?0Ih8Y6GWQ;U>dkdXtQaQ&8H|TGAQbuHY=F z_R83&B{1_hP7L#$^eAe?GPB_83y#HZKTwD>e-@E2P>Gk$BBb9|Ivfmdp za~s>3=aj(;xmz8n)sI}uFO$|C>0CZbcTY$Bq6~L-Bc9=vl@X#0S~Q@j8iKzuPeQE_ zQSI)wNz~CvJ>!%QszoCfUm9}h^DL!WYAN|FtMO#kpDXq74sYC87(uvv*jiCjV?Ta& zgO1D0OP3TEN3YnBpD6GnmsEolzEbGM{&VlTz_)J(o{nl0+TmNt{xL%L6G&UR$^aYC zQOA#W7R%9JsC5oTZJE>_?!Ci}mNH{0ObyUd%Q!k%5J8Z`8sR!m`~|Taje`(bLD7=a z-{-=d7w;k@DIrgU{I@K}eN`>S**Lg<@ChAf$M(&kV9TLUixqFQ>YoYHrI!K#R6`S> z%?d5hQ@&;Gje<|uRQZb%Hhibocl9(buI?=0aZW{JYXx?ZS@Lr%G8L<d+riEi2~+{HfHK{K^VrGYNi{2-WJOiC>Pz?f*)cxKCl>1H1=$jb!^ zpmYw>eoiM0Hy7$xbbX_e5o*+{7T2&-t%-h4i7MMo;k|tSqQAeNkwHS9hWY#EV7r3| zTmOmN{;b9OUZpp`LP(I9Wo%R#$b6YdH7GD4*p6>a2N2A04pQ*n;INQMh%+mj;x7>S z_(H?uJ^n!r1)kJH1*s+%$al#?C^Cw{H@RA^QGB=Dubyc)XUaY>f`(VKTlIO-YNCp{1n zOl*>jT?Dtf5fD$DY-j&B*Xmn|2-u2OB zBL@-lFs5lhcQKXBR*cIXmi%~EJcc^5#Xpg!E^A6sXf1#$qJGRpmU~A zcdj-cvBfx(fIRAMU(1obztJR%I7v3R-%$#~r!0sS^I(iC*5i6296*88A7I=_JhU3p zya!aCti0R5*RFT%LW0R|;u&oJ6=P-c$le4J0bi}u!!@;xzao|l6fJ{;Mld9hGhrJg zr_B)=4yktp)yPB@tCC_L9h1>GzXD6DA!W7xt{1)8!07~gONkEWC8@y%lciB{9ojy) zWm$drJ_9uVJ>Q$-`@q%OM7_S>(K=__CGYB~@@mE^Z=eT|x0Rv?Z-N)LLWR zod*Zy3v)iMX@usPX-OKBDgC8yq?fMhqf8H)A&C)Hi29YFn!NVf5!J0-F{wC&L5-3`#id=4?=2>Zp6Pdu4N6#bG&atu7 z8IET&ciXy_Tp4YjMx3yIAbw#_e2#jgGJ~ogkv-|M7|%Gio%2@mnS89NKUOM#Bzg4_ z9e9oN;^m>G*#?)AawODi6YckRPmkSKD_4b4WFpj|@|eS!B0WN@?QscYzTH`~6e%iz z!z1>ps)CG37%(E=kZ_>re)@ODv^0^=rWU^*m;6M&gD10EYImO98JVabRe5{#wrogYUKPB@_(#e7Ej9_x;n1oHDj5GawU)A&1hWj|HzJB(q{vMTX>jOW;Jz zBsW&SqTaR7!NXXg_A}$XnFpg_n)Zi;{e9eb*k|b(y$a}12boJ7rqQXQpVhU8HxHTl zt8Ln!KLFyfq!%}hdMXle^qajw2g6S{z&7tQ6J(w9 z3+!HTO{_TqM{9o$RR~lKFf4b4(xLUP?QG;McNFQc_Yd_mig9Ejy9%q~Ye>rIn3};U z)w&1@QCK;cC(;x0G&YuSad+>{c@ZsFJcUdcs@PP-x{mrO)|6_#CjMlXsMJx;Cr?FF zVFrlt@$Z-Ll^*7d0#`5Uez@bb{Xn(BQLhScBhF!6+aIso0=l{PP7P(6-ru>nVy%AP z+|eZpY(ooMU7rtG$l#14v=Z?@ebOjm(A2)5k_${|wAA$oq+;42wiS78ezjgWWnTrF z`1!i2h{fM91aD8uxz?tZpE(PsL37e3$*I6%un5Bzzpn10p`j72R;3=Oaug_|Z(y)@ z9$SJN@-5d1tNIy0=7|d&_HAnDx!yDd-u#qmfuDh)0a_CVje{hvQz9rDFHJTpQ0Dg@ zGQ3t*gZlcFSXfx%OG@Cds&NDROxd^osY_)abmo^dKMUY!R~kGH%*;rutPF@Mx$zrv z6Q1soKnYYRW#;Bi-!H)>Br0<`y+Wy~p7_<>{ljuG`Dpje=v1x}-ND<)bWBr|<}v6B zkDTUZ^@VsH>CyR}ml4j2rB{}0q8eGwX>ExkI9yZN0)(P}$N(yi$AxmBY#Xj`(7zs{ zJbn2&jE`-*0lww_r;|fNaWm_xp;c9JHIv|RExZGKP%18qjgYa);`N-^VqXNVz{~)~ z?^&D;ouy!pKPy?%@xH`A zSR z7x%N3@o&{YEjfa|1;*eW_4TU{ zt;qCcY3Hj(<0DJuny*QL!y!StcG{>bhpUP%eVMq=1xcR>yZT8X9)1;rXOmQjPcANs zr>&Qb{rr66;s|4v3iGmQlMjr9j;G6pqNs%;TsyVNd3{i~hpDX8ugdcnd&UQJzj)rH zh>S6#n`cCJ9CwHv<2Ht$o`R5(h#r||VB?%J?s5W48;^o)b`Pi1^~}5{Y19lg{&W@LfHt*gc1`w$RfLrK{~H?A1$5 z;5v?AIhpN%gQsR6+Act9-3y z8>jCTMnWQq-^s3#Lb|WalgB$k3F>}lyCxs<2&A;LS0}s#<|hPx9kM#B+Lu2DiD_3P zelg;N!80(j@HNc2pXs}re%sHi+{aqBt~qUOy86?zN>7)yiCEJqy@2Gh#gzJE6j6Rx zBQK{77zW?gLWtQ20Dzntu16k9^N>DQ@Nmbx*mOg=F=k)8VJfM%y(Xu41;8YCz+@K| z9u7vhlT`BOnk_oMTeC;u@OhhoTeA`^34^iMihCLM_uVD>rI-9@4l7ocZl@DJ8FWZU zB0lRBIqkHj4#pE&mD(X!e!~;G$`7f47k* zOznM2@`&KM(|f5}sz)z%2}yJ5YmMj5Zwzr-W?v3R&@KuJ+l0zo==N@)nsbMHqHV}w z7#_ntMGCNM21RuH^SYG+RH0sHUsF2z7ams57@2xbPj0y5)8h+caqv@P^q!do+}>+X zzUBx|mikTawzXWYzJ4(AqAJpBF4ObmD_@gyg->oFGB6`k(8+?rFRV5P1yDkFM=8(c z%RI)iG(rKtq-^V%B_(R9;tk6WIzA?x@cESTXg zWYDBxkoNB5v6J8BP&n@HVtBNb@r+XYpjgub zR4oE*$ffXJuh2g8TCaLnpNoSxJ~Jx@ayx9z5Osa)=AI#bg^5eQb<6gpR%c+Qs#N*e z@XE4pAmjdI#0%pV7sIN>mNa^jTkd=<==2_#t-}9Ju&Z^|Lp$%B92@eN%=MRc)LK$% z@!XAg;dQ8bt=@ZNey7+a(dy^o;QKGP@Rb5NJYQRrGEC{J=FB(Irw-MAfoP(9RK;)&jlxSCT=W;ODCf($WqRFhqN#LR^qVhK zWhEp4`{Nnk;n0FHj}eNCZpRM`Y-@MIM&pvr7zQOZ3Ik5;CmZbR99b&22(!-07YNF) z$o0MKej-jnvQV39{TH4r2R5univa1{ASc|VOTi4c@`t2FId|xkh5typ-rdU;1j){adk@*+( zkHj{5B~eSy&HrPOOvl_FJ98)0V;^d`0-u0FTslgiLBQVGSTiSyu zgMGAu&R}SbNa-DgKJb?;fe3Qys$?=;5?V`eRiq*Kj$I`}Z*x4rC~eNM=DsOq(=nUW>(+7o@O8K-_U(X? zTyg032nXKax5W~SF5|eBj%r8Fa>i!ejC72*sd}zJ)t7Xy!gFvM`c4@*Iw>z$u)j_l zR-Uqxymg}>Ti>i%9j*4kwfC33i~kyIQ``n)r(L z!|H2*)Mwj4dk%e*L0tgFdW185>j4<7YwLXwcOsed`%6mS{+=&d@d!B}GkbDV*0 zNIWzW^|trz!&;qeI&mPiVDOUL70xpqVv0fpN9tjpu)@1LD9D<9}9{57j9!W$`zC6&i zl9lKkmPh`x)5+h>>JtiRNNBW5$_)%-)#+SVSGsjX2T=+SRX05>yJZd`1hyk<@{%1+ zDu^k>J$d*Qz6BZMwHx!@O**^Tx&fsHDw%$@J0nfj^je^Ihy*aIx{B(hkBvSvh46Z9 zRO)BjjXL_IHXKo~$4es=8Wxk;Y+&nVBCXA;=MVuLgVn8Mk(*y^+kP3f?Pr~4^A}hXj9UHS}qeI%XKD3KhHnkrNH0(Y20BWl&!Kfm`EVh2;i5C zpirU^K0nc2-I{cqvjZKVx z=&hH#-d=gDWjVE}cMNAPJf;#NYdQ=h`twjX6yquXuCNgGx1~uk{YHAmFpQF`ZLGC=~ukEyj?cFDI zH=@XvV#AY1EY4qb`y*;Ki>KuFB|2|toL7__Cr0S1Dl{s#y0=~7HSq~&7lpBc*VLua zvv3r&-LM*{hq%IYP7<@)dG-G$kMrZaqs(MYoZ zugEeJ@u(ip9rMoVtoFe;dF`^Br5x7v!rr5`hb5mJ#ocGqXHnm9m`yILjd0>UQSMv) z^v}l5^bM6RZ6M%{mkI) zHOoSp&dX)*xUt+kXscna#a`XxI;Ul2Sxa^i5sZc=(Q)oA^2-_;!pfYHAul+oA@Ilelm;rw@FYR+SIaWS?;_ zUdw<|qqaYq(nqu>rG48E9dYAoT6GH;QRuBYK1}W#C_Z_?7~k*pJ3?MzVt&rhZTsBy zw?nN$_Z>kimtwWcy`0?G#!)&7GjOcxCQps@p&ml8>~z(t=sjhR$6aFh!Vw5GA(lTh z5GM)jCwloa6a}7mdfqNYE7oi`Jv$m5>5qR%9eZ=)=a z+K4j5NpcDHHdepCS+P*{@o=yNp&TE(Sd4b0Notqso-Kt_mhDk1<-fa>T4KdY2N`U) zxu41vD%T&k$Gl?CW81%7r#-o1TZ0&PCcy}L4TPiV;sz`|S!&w8-s$rLdM zF&)>@`7=)65PWn#oi|8tXNb|((2ojf9d0fNZ^l7xY~dX~%*Xf-v2W-2n$i~s!4?H; z2qbQscFN21tqB{|x1+(^G~xQSrvX&Y;V-%?b1}zjBQX{GOFcVYTcwm>>}>6^HA=$x zn+z^Biv_5}0!#@7z1~YXJFCT2?D^jm+kH7jAqBo?M@ZdMl|2|66oLnSJXUOJtVLxe z0vH)N^t*qrjq=eFRMV>BFEfS)-2RzKlt973;d3D}4edwIE>kGc5-o=JV56ird)RlS z{Jg@0t-b#Ife80%!E~(7`qkZ8O~Q-8_{j7G&tqwX&&>^tm-#*{v7j-f1n0}mCR#7P z-4FkajD2$9?4Fc7-C_|0Z_G^bxIs%tWk|aFgSQ(qkM+5PRh=g&ZeAZg35$-kn~}_;~&fP-dCNCzg>{gyW!~LZpn?aZ~Va3~H0Ta)z z<4XPVk@;#%1S@fq<(2#8T04#8$mz>vM;(jek0>Qh!K%t5*4tU(fVYwD3Ri~=D!AmI zV$Dt#TEDX7{lpW%tF&DOlTO)vZodn_%wYu~)ZQ}Qo^cBbDHd{YajkzNxttQW>ST<^ z2~^xhB_y1sjIF5;xchvCn{QVugIE2eYZDZ!-Y-4lJdb34*k({@M zJ5!9Di^||~(IZ4iOoAbtggao+CaYvJynmB^;4r-tY2gS_*P!?U?hlEX;l+^*{%B2n z)|1j9wOHQQ^5Xha>{Cu8_w^8=#6;Dz7kU~RgTqn;ynDm6{xdlkf2vk0UK^oS3yVy4 zE+v&qnlYtPHBk#X&2}r7`@K`J@^e~Qm?iRJ*tbAaZDZTmB&mWMkZp7Kj7^kth#_uX z5z>gC(8Xz|Ie(+#&wiF3;Aey|Db(R*-U)!6;l_5@u?-$>j0SgEl5+c}Lfe-$p-dFH zB_$bC<)x6#A_2Uuo8=^l1@}vK!gvbF#b&MoH8ac3xMxUz$LFb8KU(x$YhtHanM_sw zYOFMBX2iNNSe&a}!;G9nv(tsW4@%3iQcqczOCF*JOBQ@4Orw=o?_vc(9$hfO`>U6& zyY_CUa9pASiJpmv`@oR!k;&$`h8!)$uS=}d-fPddfIdMDUW@%3y1LI(1Q=e$)sz(QC*E;Nfl99YTgk+|@jl`+iF?<_D?4YqV0Zl)lO8YWC@1ZWW^mi{5ePQN<~FQ2NMG$|K{py5akJa zkezmqhN)>MGMp$7=sOo2(7ppv``dCIwf&MaQQis7S596kkiw8Do(jO?EY4iJ4Hec6 z4Hymzu`w)cI9Pbq6GPtTP)x&Lmk;FT=ZCB4>(5}c0?;2l`p&?>&<;2(P8a3lOTNP# zdEzF5qDpkRR&PZC&cS{7xD@qV;(g5X%xI?m$9Q +
+
+

Module name

+

This module was written to extend the functionality of ... to support ... and allow you to ...

+
+
+ + +
+
+
+

Installation

+
+
+

To install this module, you need to: +

    +
  • ...
    • +
+

+
+
+
+ + + +
+
+
+
+ +
+
+
+

Configuration

+
+
+

To configure this module, you need to: +

    +
  • ...
    • +
+

+
+
+
+ + + +
+
+
+
+ +
+
+
+

Usage

+
+
+

To use this module, you need to: +

    +
  • ...
    • +
+

+

For further information, please visit: +

+

+
+
+
+ + + +
+
+
+
+ +
+
+
+

Known issues / Roadmap

+
+
+

+

    +
  • ...
    • +
+

+
+
+
+ + + +
+
+
+
+ +
+
+
+

Credits

+
+
+

Contributors

+ +
+
+

Maintainer

+

+ This module is maintained by the OCA.
+ OCA, or the Odoo Community Association, is a nonprofit organization whose mission is to support the collaborative development of Odoo features and promote its widespread use.
+ To contribute to this module, please visit http://odoo-community.org.
+ +

+
+
+
diff --git a/project_task_stage_change_restriction/tests/__init__.py b/project_task_stage_change_restriction/tests/__init__.py new file mode 100644 index 0000000000..b49560d44d --- /dev/null +++ b/project_task_stage_change_restriction/tests/__init__.py @@ -0,0 +1,4 @@ +# Copyright (C) 2025 Cetmix OÜ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from . import test_stage_change_restriction diff --git a/project_task_stage_change_restriction/tests/test_stage_change_restriction.py b/project_task_stage_change_restriction/tests/test_stage_change_restriction.py new file mode 100644 index 0000000000..884038a383 --- /dev/null +++ b/project_task_stage_change_restriction/tests/test_stage_change_restriction.py @@ -0,0 +1,277 @@ +# Copyright (C) 2025 Cetmix OÜ +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import SUPERUSER_ID +from odoo.exceptions import UserError +from odoo.tests import common as tests_common + +from odoo.addons.base.tests.common import BaseCommon + + +@tests_common.tagged("-at_install", "post_install") +class TestStageChangeRestriction(BaseCommon): + """Validate stage-change & creation access rules for project tasks.""" + + @classmethod + def setUpClass(cls): + super().setUpClass() + env = cls.env + + gp_user = env.ref("project.group_project_user") + gp_manager = env.ref("project.group_project_manager") + try: + cls.grp_sales_admin = env.ref("sale.group_sale_manager") + except ValueError: + cls.grp_sales_admin = env["res.groups"].create( + {"name": "Sales / Manager (Test)"} + ) + + def _mk_user(login, groups): + return ( + env["res.users"] + .with_user(SUPERUSER_ID) + .create( + { + "name": login.replace("_", " ").title(), + "login": login, + "groups_id": [(4, g.id) for g in groups], + } + ) + ) + + cls.user_dev = _mk_user("dev_user", [gp_user]) + cls.user_pm = _mk_user("pm_user", [gp_user, gp_manager]) + cls.user_sales = _mk_user("sales_user", [gp_user, cls.grp_sales_admin]) + + cls.project = ( + env["project.project"] + .with_user(SUPERUSER_ID) + .create( + { + "name": "Demo Project", + "user_id": cls.user_pm.id, + } + ) + ) + + Stage = env["project.task.type"].with_user(SUPERUSER_ID).create + cls.stage_free = Stage({"name": "Free"}) + cls.stage_assigned = Stage( + {"name": "Assigned Only", "allow_assigned_only": True} + ) + cls.stage_pm = Stage( + {"name": "Project Manager Only", "allow_project_manager": True} + ) + cls.stage_group = Stage( + { + "name": "Sales Only", + "allow_group_ids": [(6, 0, [cls.grp_sales_admin.id])], + } + ) + cls.stage_assigned_or_pm = Stage( + { + "name": "Assigned OR PM", + "allow_assigned_only": True, + "allow_project_manager": True, + } + ) + cls.stage_assigned_or_group = Stage( + { + "name": "Assigned OR Sales", + "allow_assigned_only": True, + "allow_group_ids": [(6, 0, [cls.grp_sales_admin.id])], + } + ) + cls.stage_pm_or_group = Stage( + { + "name": "PM OR Sales", + "allow_project_manager": True, + "allow_group_ids": [(6, 0, [cls.grp_sales_admin.id])], + } + ) + + cls.task_tpl = ( + env["project.task"] + .with_user(SUPERUSER_ID) + .create( + { + "name": "Template Task", + "project_id": cls.project.id, + "stage_id": cls.stage_free.id, + } + ) + ) + + def _clone_task(self, acting_user, *, assignees=None, stage=None): + """Copy template and return it **as** ``acting_user``. + + :param acting_user: user performing follow‑up actions + :param assignees: list/tuple of users assigned to the task + :param stage: optional initial stage + """ + vals = { + "user_ids": [(6, 0, [u.id for u in (assignees or [])])], + "project_id": self.project.id, + } + if stage: + vals["stage_id"] = stage.id + return self.task_tpl.copy(vals).with_user(acting_user) + + def _ok_move(self, task, user, stage): + """ + Assert that `user` is allowed to move `task` to `stage`. + + :raises AssertionError: if the stage was not applied + """ + task.with_user(user).write({"stage_id": stage.id}) + self.assertEqual(task.stage_id, stage) + + def _fail_move(self, task, user, stage): + """ + Assert that `user` is NOT allowed to move `task` to `stage`. + + :raises UserError: if the write does not fail as expected + """ + with self.assertRaises(UserError): + task.with_user(user).write({"stage_id": stage.id}) + + def _ok_create(self, creator, stage, *, assignees=None): + """ + Assert that `creator` may create a task in `stage` (with optional assignees). + + :returns: the newly created task record + :raises AssertionError: if the task is not in the expected stage + """ + rec = ( + self.env["project.task"] + .with_user(creator) + .create( + { + "name": "Task", + "project_id": self.project.id, + "stage_id": stage.id, + "user_ids": [(6, 0, [u.id for u in (assignees or [])])], + } + ) + ) + self.assertEqual(rec.stage_id, stage) + + def _fail_create(self, creator, stage, *, assignees=None): + """ + Assert that `creator` may NOT create a task in `stage`. + + :raises UserError: if the create does not fail as expected + """ + with self.assertRaises(UserError): + self.env["project.task"].with_user(creator).create( + { + "name": "Bad", + "project_id": self.project.id, + "stage_id": stage.id, + "user_ids": [(6, 0, [u.id for u in (assignees or [])])], + } + ) + + def test_move_free(self): + task = self._clone_task(self.user_dev) + for u in (self.user_dev, self.user_pm, self.user_sales): + self._ok_move(task, u, self.stage_free) + + def test_move_assigned_only(self): + task = self._clone_task(self.user_dev, assignees=[self.user_dev]) + self._ok_move(task, self.user_dev, self.stage_assigned) + self._fail_move(task, self.user_pm, self.stage_assigned) + self._fail_move(task, self.user_sales, self.stage_assigned) + + def test_move_pm_only(self): + task = self._clone_task(self.user_dev) + self._ok_move(task, self.user_pm, self.stage_pm) + self._fail_move(task, self.user_dev, self.stage_pm) + self._fail_move(task, self.user_sales, self.stage_pm) + + def test_move_group_only(self): + task = self._clone_task(self.user_dev) + self._ok_move(task, self.user_sales, self.stage_group) + self._fail_move(task, self.user_dev, self.stage_group) + self._fail_move(task, self.user_pm, self.stage_group) + + def test_move_assigned_or_pm(self): + task = self._clone_task(self.user_dev, assignees=[self.user_dev]) + self._ok_move(task, self.user_dev, self.stage_assigned_or_pm) + self._ok_move(task, self.user_pm, self.stage_assigned_or_pm) + self._fail_move(task, self.user_sales, self.stage_assigned_or_pm) + + def test_move_assigned_or_group(self): + task = self._clone_task(self.user_dev, assignees=[self.user_dev]) + self._ok_move(task, self.user_dev, self.stage_assigned_or_group) + self._ok_move(task, self.user_sales, self.stage_assigned_or_group) + self._fail_move(task, self.user_pm, self.stage_assigned_or_group) + + def test_move_pm_or_group(self): + task = self._clone_task(self.user_dev) + self._ok_move(task, self.user_pm, self.stage_pm_or_group) + self._ok_move(task, self.user_sales, self.stage_pm_or_group) + self._fail_move(task, self.user_dev, self.stage_pm_or_group) + + def test_superuser_bypass_move(self): + task = self._clone_task(self.user_dev) + task.with_user(SUPERUSER_ID).write({"stage_id": self.stage_pm.id}) + self.assertEqual(task.stage_id, self.stage_pm) + + def test_create_free(self): + for u in (self.user_dev, self.user_pm, self.user_sales): + self._ok_create(u, self.stage_free) + + def test_create_assigned_only(self): + self._ok_create(self.user_dev, self.stage_assigned, assignees=[self.user_dev]) + self._fail_create(self.user_pm, self.stage_assigned, assignees=[self.user_dev]) + self._fail_create( + self.user_sales, self.stage_assigned, assignees=[self.user_dev] + ) + + def test_create_pm_only(self): + self._ok_create(self.user_pm, self.stage_pm) + self._fail_create(self.user_dev, self.stage_pm) + self._fail_create(self.user_sales, self.stage_pm) + + def test_create_group_only(self): + self._ok_create(self.user_sales, self.stage_group) + self._fail_create(self.user_dev, self.stage_group) + self._fail_create(self.user_pm, self.stage_group) + + def test_create_assigned_or_pm(self): + self._ok_create( + self.user_dev, self.stage_assigned_or_pm, assignees=[self.user_dev] + ) + self._ok_create(self.user_pm, self.stage_assigned_or_pm) + self._fail_create( + self.user_sales, self.stage_assigned_or_pm, assignees=[self.user_dev] + ) + + def test_create_assigned_or_group(self): + self._ok_create( + self.user_dev, self.stage_assigned_or_group, assignees=[self.user_dev] + ) + self._ok_create(self.user_sales, self.stage_assigned_or_group) + self._fail_create( + self.user_pm, self.stage_assigned_or_group, assignees=[self.user_dev] + ) + + def test_create_pm_or_group(self): + self._ok_create(self.user_pm, self.stage_pm_or_group) + self._ok_create(self.user_sales, self.stage_pm_or_group) + self._fail_create(self.user_dev, self.stage_pm_or_group) + + def test_superuser_bypass_create(self): + rec = ( + self.env["project.task"] + .with_user(SUPERUSER_ID) + .create( + { + "name": "SU task", + "project_id": self.project.id, + "stage_id": self.stage_assigned.id, + } + ) + ) + self.assertEqual(rec.stage_id, self.stage_assigned) diff --git a/project_task_stage_change_restriction/views/project_task_stage_views.xml b/project_task_stage_change_restriction/views/project_task_stage_views.xml new file mode 100644 index 0000000000..b06a449511 --- /dev/null +++ b/project_task_stage_change_restriction/views/project_task_stage_views.xml @@ -0,0 +1,27 @@ + + + + project.task.type.form.restriction + project.task.type + + + + + + + + + + + + From 787ad7362a101dc7b7e32a98fbcf38f5234a2412 Mon Sep 17 00:00:00 2001 From: mymage Date: Tue, 22 Jul 2025 06:44:00 +0000 Subject: [PATCH 2/4] Translated using Weblate (Italian) Currently translated at 100.0% (18 of 18 strings) Translation: project-16.0/project-16.0-project_task_stage_change_restriction Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_stage_change_restriction/it/ --- .../i18n/it.po | 129 ++++++++++++++++++ 1 file changed, 129 insertions(+) create mode 100644 project_task_stage_change_restriction/i18n/it.po diff --git a/project_task_stage_change_restriction/i18n/it.po b/project_task_stage_change_restriction/i18n/it.po new file mode 100644 index 0000000000..35f219d345 --- /dev/null +++ b/project_task_stage_change_restriction/i18n/it.po @@ -0,0 +1,129 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * project_task_stage_change_restriction +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 16.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2025-07-28 09:25+0000\n" +"Last-Translator: mymage \n" +"Language-Team: none\n" +"Language: it\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n != 1;\n" +"X-Generator: Weblate 5.10.4\n" + +#. module: project_task_stage_change_restriction +#: model:ir.model.fields,field_description:project_task_stage_change_restriction.field_project_task_type__allow_assigned_only +#: model:project.task.type,name:project_task_stage_change_restriction.demo_stage_assigned_only +msgid "Assigned Only" +msgstr "Solo assegnati" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,legend_blocked:project_task_stage_change_restriction.demo_stage_assigned_only +#: model:project.task.type,legend_blocked:project_task_stage_change_restriction.demo_stage_free +#: model:project.task.type,legend_blocked:project_task_stage_change_restriction.demo_stage_group_only +#: model:project.task.type,legend_blocked:project_task_stage_change_restriction.demo_stage_pm_only +msgid "Blocked" +msgstr "Bloccato" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,name:project_task_stage_change_restriction.demo_stage_free +msgid "Free" +msgstr "Libero" + +#. module: project_task_stage_change_restriction +#: model:ir.model.fields,field_description:project_task_stage_change_restriction.field_project_task_type__allow_group_ids +msgid "Group Members" +msgstr "Membri del gruppo" + +#. module: project_task_stage_change_restriction +#: model_terms:ir.ui.view,arch_db:project_task_stage_change_restriction.view_project_task_type_form_restriction +msgid "If enabled, only the project manager can move tasks into this stage." +msgstr "" +"Se abilitata, solo il responsabile del progetto può spostare i lavori tra le " +"fasi." + +#. module: project_task_stage_change_restriction +#: model_terms:ir.ui.view,arch_db:project_task_stage_change_restriction.view_project_task_type_form_restriction +msgid "" +"If enabled, only users assigned to the task can move it into this stage." +msgstr "" +"Se abilitata, solo gli utenti assegnati al lavoro possono spostarlo in " +"questa fase." + +#. module: project_task_stage_change_restriction +#: model:project.task.type,legend_normal:project_task_stage_change_restriction.demo_stage_assigned_only +#: model:project.task.type,legend_normal:project_task_stage_change_restriction.demo_stage_free +#: model:project.task.type,legend_normal:project_task_stage_change_restriction.demo_stage_group_only +#: model:project.task.type,legend_normal:project_task_stage_change_restriction.demo_stage_pm_only +msgid "In Progress" +msgstr "In lavoro" + +#. module: project_task_stage_change_restriction +#: model_terms:ir.ui.view,arch_db:project_task_stage_change_restriction.view_project_task_type_form_restriction +msgid "Members of selected groups can move tasks into this stage." +msgstr "" +"I membri dei gruppi selezionati possono spostare i lavori in questa fase." + +#. module: project_task_stage_change_restriction +#: model:ir.model.fields,field_description:project_task_stage_change_restriction.field_project_task_type__allow_project_manager +msgid "Project Manager" +msgstr "Responsabile progetto" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,name:project_task_stage_change_restriction.demo_stage_pm_only +msgid "Project Manager Only" +msgstr "Solo responsabile progetto" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,name:project_task_stage_change_restriction.demo_stage_group_only +msgid "Project Users Only" +msgstr "Solo utenti progetto" + +#. module: project_task_stage_change_restriction +#: model:project.task.type,legend_done:project_task_stage_change_restriction.demo_stage_assigned_only +#: model:project.task.type,legend_done:project_task_stage_change_restriction.demo_stage_free +#: model:project.task.type,legend_done:project_task_stage_change_restriction.demo_stage_group_only +#: model:project.task.type,legend_done:project_task_stage_change_restriction.demo_stage_pm_only +msgid "Ready" +msgstr "Pronto" + +#. module: project_task_stage_change_restriction +#: model:project.project,name:project_task_stage_change_restriction.demo_project_restricted +msgid "Restricted Demo Project" +msgstr "Progetto demo limitato" + +#. module: project_task_stage_change_restriction +#. odoo-python +#: code:addons/project_task_stage_change_restriction/models/project_task.py:0 +#, python-format +msgid "" +"Sorry, you are not allowed to move the task '%(task)s' into the stage " +"'%(stage)s'." +msgstr "" +"Non si è abilitati allo spostamento del lavoro '%(task)s' alla fase " +"'%(stage)s'." + +#. module: project_task_stage_change_restriction +#: model_terms:ir.ui.view,arch_db:project_task_stage_change_restriction.view_project_task_type_form_restriction +msgid "Stage Change Restriction" +msgstr "Limitazione modifica fase" + +#. module: project_task_stage_change_restriction +#: model:ir.model,name:project_task_stage_change_restriction.model_project_task +msgid "Task" +msgstr "Lavoro" + +#. module: project_task_stage_change_restriction +#: model:ir.model,name:project_task_stage_change_restriction.model_project_task_type +msgid "Task Stage" +msgstr "Fase lavoro" + +#. module: project_task_stage_change_restriction +#: model:project.project,label_tasks:project_task_stage_change_restriction.demo_project_restricted +msgid "Tasks" +msgstr "Lavori" From d37c690392b97c56dd010a26f267ed76d87e87ac Mon Sep 17 00:00:00 2001 From: Mohajiro Date: Sun, 11 Jan 2026 10:55:39 +0100 Subject: [PATCH 3/4] [IMP] project_task_stage_change_restriction: pre-commit execution --- .../pyproject.toml | 3 +++ .../views/project_task_stage_views.xml | 14 +++++++------- 2 files changed, 10 insertions(+), 7 deletions(-) create mode 100644 project_task_stage_change_restriction/pyproject.toml diff --git a/project_task_stage_change_restriction/pyproject.toml b/project_task_stage_change_restriction/pyproject.toml new file mode 100644 index 0000000000..4231d0cccb --- /dev/null +++ b/project_task_stage_change_restriction/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/project_task_stage_change_restriction/views/project_task_stage_views.xml b/project_task_stage_change_restriction/views/project_task_stage_views.xml index b06a449511..6ffb3de633 100644 --- a/project_task_stage_change_restriction/views/project_task_stage_views.xml +++ b/project_task_stage_change_restriction/views/project_task_stage_views.xml @@ -5,23 +5,23 @@ project.task.type - - - + + - - - - + + From 238f8373b319c968dce72e757679a03a81994412 Mon Sep 17 00:00:00 2001 From: Mohajiro Date: Sun, 11 Jan 2026 10:55:39 +0100 Subject: [PATCH 4/4] [MIG] project_task_stage_change_restriction: Migration from 16.0 Standard migration from 16.0 to 18.0. Task: 5166 --- .../README.rst | 16 ++++++---------- .../__manifest__.py | 2 +- .../models/project_task.py | 2 -- .../tests/test_stage_change_restriction.py | 18 +++++++++++++++--- 4 files changed, 22 insertions(+), 16 deletions(-) diff --git a/project_task_stage_change_restriction/README.rst b/project_task_stage_change_restriction/README.rst index 60bd9c9b50..08c8c57f8a 100644 --- a/project_task_stage_change_restriction/README.rst +++ b/project_task_stage_change_restriction/README.rst @@ -1,7 +1,3 @@ -.. image:: https://odoo-community.org/readme-banner-image - :target: https://odoo-community.org/get-involved?utm_source=readme - :alt: Odoo Community Association - ===================================== Project Task Stage Change Restriction ===================================== @@ -17,17 +13,17 @@ Project Task Stage Change Restriction .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png :target: https://odoo-community.org/page/development-status :alt: Beta -.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html :alt: License: AGPL-3 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproject-lightgray.png?logo=github - :target: https://github.com/OCA/project/tree/16.0/project_task_stage_change_restriction + :target: https://github.com/OCA/project/tree/18.0/project_task_stage_change_restriction :alt: OCA/project .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png - :target: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_stage_change_restriction + :target: https://translation.odoo-community.org/projects/project-18-0/project-18-0-project_task_stage_change_restriction :alt: Translate me on Weblate .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png - :target: https://runboat.odoo-community.org/builds?repo=OCA/project&target_branch=16.0 + :target: https://runboat.odoo-community.org/builds?repo=OCA/project&target_branch=18.0 :alt: Try me on Runboat |badge1| |badge2| |badge3| |badge4| |badge5| @@ -88,7 +84,7 @@ Bug Tracker Bugs are tracked on `GitHub Issues `_. In case of trouble, please check there if your issue has already been reported. If you spotted it first, help us to smash it by providing a detailed and welcomed -`feedback `_. +`feedback `_. Do not contact contributors directly about support or help with technical issues. @@ -118,6 +114,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose mission is to support the collaborative development of Odoo features and promote its widespread use. -This module is part of the `OCA/project `_ project on GitHub. +This module is part of the `OCA/project `_ project on GitHub. You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/project_task_stage_change_restriction/__manifest__.py b/project_task_stage_change_restriction/__manifest__.py index 6bd07342a1..0910553834 100644 --- a/project_task_stage_change_restriction/__manifest__.py +++ b/project_task_stage_change_restriction/__manifest__.py @@ -4,7 +4,7 @@ { "name": "Project Task Stage Change Restriction", "summary": "Restrict project task stage", - "version": "16.0.1.0.0", + "version": "18.0.1.0.0", "category": "Project", "author": "Odoo Community Association (OCA), Cetmix", "license": "AGPL-3", diff --git a/project_task_stage_change_restriction/models/project_task.py b/project_task_stage_change_restriction/models/project_task.py index e46770908d..2e29a8bd9e 100644 --- a/project_task_stage_change_restriction/models/project_task.py +++ b/project_task_stage_change_restriction/models/project_task.py @@ -43,8 +43,6 @@ def _check_stage_restriction(self, vals): return True new_stage = self.env["project.task.type"].browse(stage_id) - if not new_stage: - return True for task in self: if not self._is_move_allowed(task, new_stage, self.env.user): diff --git a/project_task_stage_change_restriction/tests/test_stage_change_restriction.py b/project_task_stage_change_restriction/tests/test_stage_change_restriction.py index 884038a383..079a9fef67 100644 --- a/project_task_stage_change_restriction/tests/test_stage_change_restriction.py +++ b/project_task_stage_change_restriction/tests/test_stage_change_restriction.py @@ -55,17 +55,26 @@ def _mk_user(login, groups): ) Stage = env["project.task.type"].with_user(SUPERUSER_ID).create - cls.stage_free = Stage({"name": "Free"}) + cls.stage_free = Stage({"name": "Free", "project_ids": [(4, cls.project.id)]}) cls.stage_assigned = Stage( - {"name": "Assigned Only", "allow_assigned_only": True} + { + "name": "Assigned Only", + "allow_assigned_only": True, + "project_ids": [(4, cls.project.id)], + } ) cls.stage_pm = Stage( - {"name": "Project Manager Only", "allow_project_manager": True} + { + "name": "Project Manager Only", + "allow_project_manager": True, + "project_ids": [(4, cls.project.id)], + } ) cls.stage_group = Stage( { "name": "Sales Only", "allow_group_ids": [(6, 0, [cls.grp_sales_admin.id])], + "project_ids": [(4, cls.project.id)], } ) cls.stage_assigned_or_pm = Stage( @@ -73,6 +82,7 @@ def _mk_user(login, groups): "name": "Assigned OR PM", "allow_assigned_only": True, "allow_project_manager": True, + "project_ids": [(4, cls.project.id)], } ) cls.stage_assigned_or_group = Stage( @@ -80,6 +90,7 @@ def _mk_user(login, groups): "name": "Assigned OR Sales", "allow_assigned_only": True, "allow_group_ids": [(6, 0, [cls.grp_sales_admin.id])], + "project_ids": [(4, cls.project.id)], } ) cls.stage_pm_or_group = Stage( @@ -87,6 +98,7 @@ def _mk_user(login, groups): "name": "PM OR Sales", "allow_project_manager": True, "allow_group_ids": [(6, 0, [cls.grp_sales_admin.id])], + "project_ids": [(4, cls.project.id)], } )