--with-hooks="timesyncd.conf" should uncomment 'option ntp_servers'

[perkelix]

As reported at Debian, dhcpcd apparently started commenting out 'option ntp_servers' at commit aa1a876. This results in dhcpcd shipping without NTP support even in cases when --with-hooks="timesyncd.conf" or --with-hooks="ntp.conf" was passed to ./configure. IMHO, the build should uncomment the option in dhcpcd.conf if either hook was explicitly configured.

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

• Create Plan

Examples

• Example 1
• Example 2

---

🔗 Similar Issues

Related Issues

• Rapid commit is not necessarily safe to enable #499
• dhcpcd configured DNS server disappears when using systemd-resolved #500
• Sends an exit code before succesfully acquiring an IP #537

👤 Suggested Assignees

• tholin
• KenMilmore
• perkelix

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[AdamPerkins]

Ignoring the previous AI nonsense I strongly recommend 'option ntp_servers' is active by default.

I don't understand why it was commented out without any explanation in the commit.

[perkelix]

@rsmarples What's your take on this one?