-
-
Notifications
You must be signed in to change notification settings - Fork 267
chore: stop using swaps fetchTokens function #7712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cursor update the changelog.md under assets-controllers with a breaking change |
|
I've successfully updated the assets-controllers CHANGELOG.md file with the breaking change information for the swaps token fetching removal. What I did:
The changelog entry follows the project's established format and clearly marks this as a BREAKING change with reference to PR #7712. This should satisfy the CI check that was failing due to missing changelog updates. |
…r swaps token fetching removal Co-authored-by: juan.gutierrez <juan.gutierrez@consensys.net>
|
@cursor update the description of this PR, specifically the Explanation section |
|
you have a conflict , happy to re approve once resolved |
|
@cursor resolve the merge conflicts |
|
Perfect! I've successfully resolved the merge conflicts. Here's what I did: Merge Conflict Resolution Summary:
The resolved CHANGELOG.md now includes:
The branch is now up to date with main and the conflicts are resolved. The PR should be ready for review again! |
Co-authored-by: juan.gutierrez <juan.gutierrez@consensys.net>
|
@metamaskbot publish-preview |
Explanation
This PR removes unused swaps-related functionality from the TokenSearchDiscoveryDataController to simplify the token search and discovery system.
This PR causes BREAKING changes on Mobile but not Extension. I have created this PR to fix the breaking changes on Mobile:
References
https://consensyssoftware.atlassian.net/browse/ASSETS-2533
Checklist
Note
Simplifies token search/discovery by removing unused swaps token fetching and state.
swapsTokenAddressesByChainIdstate and all metadata references; default state now only includestokenDisplayDataswapsSupportedChainIds,fetchTokens,fetchSwapsTokensThresholdMs) and thefetchSwapsTokensmethod;fetchTokenDisplayDatano longer calls itWritten by Cursor Bugbot for commit 32f48d0. This will update automatically on new commits. Configure here.