Skip to content

Do not use file_walk in PSyclone for finding kernels #542

@hiker

Description

@hiker

The PSyclone step analyses potential kernel files (based on the PSyclone kernel directories provided) using:

    file_lists = [list(file_walk(root, ignore_folders=[config.prebuild_folder])) for root in kernel_roots]

The problem with this is (besides performance, since Fab already has a list of all files, so there is no need to query the file system again) that a previous step might replace kernel files (e.g. if a PSyclone transmute step is done before the kernel analysis, there might be two files in the kernel directory, one the original kernel file, one a transmuted one with a slightly modified name).

This then causes failure during the analysis step (two files with the same kernel).

Instead of the above code, this step should take the files from the artefact store (and check for files that are in one of the kernel directories)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions