Skip to content

[BUG] Big issue ticket of all the bugs after testing day #167

@leske42

Description

@leske42

Don't break it into smaller issues @LeaYeh let's just fix all of them

  • check possible Content-Length overflow in the Header Field Validator

  • implement response to 100-continue properly

  • implement keepalive timeout properly ([KNOWN ISSUE] Keep-alive implementation should be different #142)

  • clean up tempfiles after throwing exception

  • don't create tempfiles for GET

  • solve leak coming from CGI Handlers on multiple CGI request (by unique ptr?) ([BUG] Leak on more than one CGI request #155)

  • Connection: close should always close the connections ([BUG] Connection: close doesn't close the connection #132)

  • Close all fds before execve() in CgiExecutor (need to fix for the session)

  • check for both -1 and 0 returns after read/recv/send

  • delete errno logs

  • ConfigParser cries if client_max_body_size doesn't end with a letter

  • our chunked response probably sucks syntactically so if we respond chunked browser cries

  • telnet doesn't work?? (postman gets our answer on successful DELETE but telnet just gets hangup)

  • main test page has wrong links and gives 403

  • GO uploader script should not print EOF error

  • remove the not-critical "critical" logs from Harl

  • if server name doesn't match we should not respond 404 but default to the first possibility

  • redirect is leading to an infinite loop for some reason

  • after refactor of config parser, POST can not create new files. It checks if the file has write permission before writing to it, but nonexisting files have no permissions

  • if we send a DELETE request for the same resource more than once, we get UNKNOWN method from the parser (which results in 501 not implemented - probably the parser is not reset somewhere

  • POST CGI without body quits from the 2nd attempt

  • the makefile should create a tmp folder if it doesnt exist yet because our webserver needs it for operation

  • use of throw in all constructors needs to be revised (maybe function try blocks can help)

  • Create demo config to answer the question: https://hackmd.io/2BmEOeDlTluQt0QLxf8YJA

  • Your server must have default error pages if none are provided.

  • You can’t use fork for anything other than CGI (like PHP, or Python, and so forth).

  • root or alias directive is missing in location block for redirect

  • epoll_create1 should be epoll_create

  • make a simple makefile

  • Setup multiple servers with different hostnames (use something curl)

  • leak when bind() failed

  • http://127.0.0.1:8080/features/upload.html doesn't work

  • review all conf files again

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinghelp wantedExtra attention is needed

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions