Get default voltage class incompatibility between config and kwargs

[kostialjn]

Environment

• Grid2op version: dev_1.12.4

Bug description

There might be some issue in the make_from_dataset_path function :

• Expected names in config.py and kwargs are not compatible:
  • config.py: "voltage_class"
  • kwargs: "voltagecontroler_class"
• Also the arguments used to call the _get_default_aux function seems to have been inverted (defaultClass and defaultClassApp)

Suggestion

In grid2op.MakeEnv.MakeFromPath:556

Current code

# Get default Voltage class
voltage_class_cfg = ControlVoltageFromFile
if "voltage_class" in config_data and config_data["voltage_class"] is not None:
    voltage_class_cfg = config_data["voltage_class"]
### Create controler for voltages
volagecontroler_class = _get_default_aux(
    "voltagecontroler_class",
    kwargs,
    defaultClassApp=voltage_class_cfg,
    defaultClass=ControlVoltageFromFile,
    msg_error=ERR_MSG_KWARGS["voltagecontroler_class"],
    isclass=True,
)

Fixed code suggestion

voltage_class_cfg = ControlVoltageFromFile
if "voltagecontroler_class" in config_data and config_data["voltagecontroler_class"] is not None:
    voltage_class_cfg = config_data["voltagecontroler_class"]
### Create controler for voltages
volagecontroler_class = _get_default_aux(
    "voltagecontroler_class",
    kwargs,
    defaultClass=voltage_class_cfg,
    defaultClassApp=ControlVoltageFromFile, # or BaseVoltageController
    msg_error=ERR_MSG_KWARGS["voltagecontroler_class"],
    isclass=True,
)