My existing fork

[sgshryock]

Hello,

A hand full of days ago I forked your repo and have been making many updates to fix issues on the particular board myself and friends are using; ESP32-S3. Many of these issue may address items on other boards as well.

I didn't want to just send a massive PR at you and thought this may be a better avenue to reach out first.

If you have time, please review my fork updates in case you are interested in any of them.

I have made many updates to processing on the board, bugs, memory leaks, and the UI. I did this on a whim for my friend group who all of which each set up a pixelix.

If you want any of the implemented features let me know. I can either send a PR of my current repo and you can cherry pick it, or I can implement the changes on a new fork specifically for you, or you can just take it as inspiration and do it yourself.

If you are not interested, please let me know that too and I won't bother you again.

Thanks for the hard work you put into this.

Tag.

[BlueAndi]

Hi,
you are welcome. I will have a look at your fork.

Contributions are always welcome of course. Small, manageable, and logically connected pull requests are preferred for easier reviews, as the changes need to be considered for all supported boards, especially regarding RAM and flash memory.

Consider that e.g. the HttpService in the latest release is not ready yet therefore commented out in any configuration. There will be issues for sure. :-) Unfortunately I pushed it to the latest release.

cu

[sgshryock]

Alright just let me know if you want me to isolate an features or fixes to your exact branch.

Thank you.

[BlueAndi]

I reviewed your commits and there are good improvements. Some of them I took already over and modified them to match a little bit better to the current sw design. If you don't mind, I appreciate isolated pull requests for the following features:

• Shutdown possibility via REST API and MQTT, by configuring it in the Topics.cpp. If you use the topic handler, it will automatically be available via REST API and via MQTT (if available). To get in homeassistant a button, a configuration file is additional required in /extra/ directory. As example see there restart.json
• Cookie based session authentication
• Remove WebSocket authentication for mobile compatibility
• OpenWeatherPlugin: Use free API as default source
• Add PixelixUpdater binary in every development board separated directory in the release package.

Destination is always the Development branch.

Thanks.

BTW I will add you to the list of contributors in the about webpage.

Which esp32-s3 board do you and your friends use?