-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Hey. Hey.
Giving this a shot and figured I'd give you some immediate feedback before I forget. It's Saturday evening after all ;)
- I'm doing my custom component / addon as a plugin. Perhaps this isn't ideal / recommended? I ask because the initial test for class_exists('Aesop_Core') doesn't come up true. I presume it's because my plugin is loading before ASE. Comments?
1.5) Is there a reason for components vs addons? Are they the same thing? If they're the same the marketing / UX person in me wants to ask: can we go with one or the other?
-
In the options method in the array that defines the form, I'm not so sure I agree with using the name as the key; the 'name' in the array looks to actually be the label; as a personal standard practice (when it makes sense) I always have a "active" => bool so it's easy to switch things on and off - either manually or programatically. I can see that being useful here.
-
Speaking of bools, any chance of getting a simple bool "switch" (i.e., on / off, yes / no, etc) as one of the available form elements? Yes, a select can do the same but... Well, hopefully you see why a switch might be nice / useful.
As usually, I probably have some other thoughts but I'll cut it short this evening. I'm getting kinda thirsty :)
mfs
p.s. I'm sorry. One more thought / suggestion...:)
If you can make the current free/ stock components available (read: as repos), that would be great. For example, I like the standard / default quote component but per the clients request, we'd like to trick it out a bit. If there's a "clean" version of the standard ASE quote component I could just start there. It's going to save me from reinventing the wheel. I'll check the ASE core code but I'm not sure I noticed what I'm looking for. I'll check again. Sorry if I was blind the first time.
Thanks again.